Skip to content

Conversation

@huydhn
Copy link
Contributor

@huydhn huydhn commented Dec 20, 2023

  • Nova build workflows are available, but none of them uploads their artifacts to nightly because the trigger wasn't set correctly https://hud.pytorch.org/hud/pytorch/data/nightly
  • A bunch of obsoleted release workflows needs to be cleaned up. With Nova build workflows in place, we don't need them anymore because they step on each other foot. They uses AWS credentials.

Testing

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 20, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 20, 2023

No ciflow labels are configured for this repo.
For information on how to enable CIFlow bot see this wiki

@huydhn huydhn marked this pull request as ready for review December 20, 2023 05:19
@huydhn huydhn marked this pull request as draft December 20, 2023 07:27
@huydhn huydhn marked this pull request as ready for review December 20, 2023 07:49
@huydhn huydhn changed the title Enable Python 3.12 build for torchdata Switch to Nova build jobs and cleanup AWS credentials Jan 12, 2024
@huydhn huydhn merged commit 9e03cb4 into main Jan 13, 2024
huydhn added a commit that referenced this pull request Jan 16, 2024
* Enable Python 3.12 build for torchdata

* Minor push to run all builds

* Build conda 3.12 with conda-build in 3.9

* Install setuptools for 3.12

* Use the correct conda env

* Figure it out

* Clean up obsolete workflows

* Clean up AWS credentials
gokulavasan added a commit that referenced this pull request Jul 15, 2024
atalman added a commit that referenced this pull request Jul 18, 2024
* Revert "Switch to Nova build jobs and cleanup AWS credentials (#1217)"

This reverts commit b2b2577.

* update branch names

* keep linux and macos use only windows changes

* test

* use correct path

* test

* test

* test

---------

Co-authored-by: atalman <[email protected]>
atalman added a commit to atalman/data that referenced this pull request Jul 18, 2024
* Revert "Switch to Nova build jobs and cleanup AWS credentials (meta-pytorch#1217)"

This reverts commit b2b2577.

* update branch names

* keep linux and macos use only windows changes

* test

* use correct path

* test

* test

* test

---------

Co-authored-by: atalman <[email protected]>
atalman added a commit that referenced this pull request Jul 23, 2024
* Bring back windows binary builds for release 0.8.0 (#1286)

* Revert "Switch to Nova build jobs and cleanup AWS credentials (#1217)"

This reverts commit b2b2577.

* update branch names

* keep linux and macos use only windows changes

* test

* use correct path

* test

* test

* test

---------

Co-authored-by: atalman <[email protected]>

* pin numpy

---------

Co-authored-by: Gokul <[email protected]>
@andrewkho andrewkho deleted the enable-py312 branch September 26, 2024 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/binaries/all CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants