Skip to content

Bring back windows binary builds for release 0.8.0 (#1286) #1288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
atalman merged 2 commits into from
Jul 23, 2024
Merged

Bring back windows binary builds for release 0.8.0 (#1286) #1288

atalman merged 2 commits into from
Jul 23, 2024

Conversation

@atalman
Copy link
Contributor

@atalman atalman commented Jul 18, 2024

No description provided.

@gokulavasan @atalman
Bring back windows binary builds for release 0.8.0 (meta-pytorch#1286)
afea665 
* Revert "Switch to Nova build jobs and cleanup AWS credentials (meta-pytorch#1217)"

This reverts commit b2b2577.

* update branch names

* keep linux and macos use only windows changes

* test

* use correct path

* test

* test

* test

---------

Co-authored-by: atalman <[email protected]>
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 18, 2024
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 18, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/data/1288

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 5 Pending

As of commit 8d33990 with merge base db57e7c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@andrewkho
Copy link
Contributor

andrewkho commented Jul 22, 2024 •
edited
Loading

I'm seeing Numpy warnings:

A module that was compiled using NumPy 1.x cannot be run in

NumPy 2.0.0 as it may crash. To support both 1.x and 2.x

versions of NumPy, modules must be compiled with NumPy 2.0.

Some module may need to rebuild instead e.g. with 'pybind11>=2.12'.

and errors like this in windows:
RuntimeError: Could not infer dtype of numpy.int64

Do we need to pin numpy < 2?

gokulavasan
gokulavasan approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@gokulavasan gokulavasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg!

@atalman atalman merged commit 775ce42 into meta-pytorch:main Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gokulavasan gokulavasan gokulavasan approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@atalman @andrewkho @gokulavasan @facebook-github-bot