Skip to content
This repository was archived by the owner on Aug 15, 2025. It is now read-only.

Pin conda-build to 3.28.4 #1698

Merged
atalman merged 2 commits into from
Feb 6, 2024
Merged

Pin conda-build to 3.28.4 #1698

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4ca26c
Pin conda-build to 3.28.4
huydhn Feb 6, 2024
4f5520f
Keep Windows setup
huydhn Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions conda/build_pytorch.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,8 @@ if [[ "$(uname)" == 'Darwin' ]]; then
"$miniconda_sh" -b -p "$tmp_conda" && \
rm "$miniconda_sh"
export PATH="$tmp_conda/bin:$PATH"
retry conda install -yq conda-build
# TODO(huydhn): We can revert the pin after https://github.com/conda/conda-build/issues/5167 is resolved
retry conda install -yq conda-build=3.28.4
elif [[ "$OSTYPE" == "msys" ]]; then
export tmp_conda="${WIN_PACKAGE_WORK_DIR}\\conda"
export miniconda_exe="${WIN_PACKAGE_WORK_DIR}\\miniconda.exe"
Expand All @@ -219,7 +220,8 @@ elif [[ "$OSTYPE" == "msys" ]]; then
pushd $tmp_conda
export PATH="$(pwd):$(pwd)/Library/usr/bin:$(pwd)/Library/bin:$(pwd)/Scripts:$(pwd)/bin:$PATH"
popd
retry conda install -yq conda-build
# TODO(huydhn): We can revert the pin after https://github.com/conda/conda-build/issues/5167 is resolved

@atalman atalman Feb 6, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since failure is with MacOS only we probably don't need to apply this constraint to windows. Only MacOS should be enough. Also I see that windows test is failing: https://github.com/pytorch/pytorch/actions/runs/7794015875/job/21254659194#step:12:2556

@huydhn huydhn Feb 6, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope that conda doesn't put us into a situation where both pinning an older version and using the latest version fail :)

retry conda install -yq conda-build=3.28.4
fi

cd "$SOURCE_DIR"
Expand Down Expand Up @@ -351,8 +353,6 @@ for py_ver in "${DESIRED_PYTHON[@]}"; do
conda install -y conda-package-handling conda==22.9.0
else
conda install -y conda-package-handling conda==23.5.2
# NS: To be removed after conda docker images are updated
conda update -y conda-build
fi

echo "Calling conda-build at $(date)"
Expand Down