-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add train_inputs Option into qMVES #593
Conversation
Hi @wjmaddox! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #593 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 89 89
Lines 5771 5773 +2
=========================================
+ Hits 5771 5773 +2
Continue to review full report at Codecov.
|
Probably a good pattern to follow more generally for other acquisition functions that may make this implicit assumption. For now this lgtm! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Balandat has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Motivation
Not every gpytorch model will store the training inputs (e.g. SVGPs) so adding a training data option into qMVES allows usage for a wider variety of gpytorch models.
Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
N/A.
Related PRs
None.