Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add train_inputs Option into qMVES #593

Closed
wants to merge 2 commits into from

Conversation

wjmaddox
Copy link
Contributor

@wjmaddox wjmaddox commented Nov 8, 2020

Motivation

Not every gpytorch model will store the training inputs (e.g. SVGPs) so adding a training data option into qMVES allows usage for a wider variety of gpytorch models.

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

N/A.

Related PRs

None.

@facebook-github-bot
Copy link
Contributor

Hi @wjmaddox!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 8, 2020
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@codecov
Copy link

codecov bot commented Nov 8, 2020

Codecov Report

Merging #593 (1216260) into master (dc868cc) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #593   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           89        89           
  Lines         5771      5773    +2     
=========================================
+ Hits          5771      5773    +2     
Impacted Files Coverage Δ
botorch/acquisition/max_value_entropy_search.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc868cc...1216260. Read the comment docs.

@Balandat
Copy link
Contributor

Balandat commented Nov 9, 2020

Probably a good pattern to follow more generally for other acquisition functions that may make this implicit assumption. For now this lgtm!

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Balandat has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@Balandat merged this pull request in a04b50f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants