Add instructions to test model after submitting #1447
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuzhao9
approved these changes
Mar 3, 2023
Contributor
xuzhao9
left a comment
xuzhao9
left a comment
There was a problem hiding this comment.
LGTM, thanks!
Note that depending on whether the machine local test runs on has a GPU, it might skip some tests that will be covered in the CI machine.
Contributor
|
@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Member
Author
|
Thanks @xuzhao9 speaking of tests, so far in this PR for example I see a lot of errors around NoneType #1446 - it's still my first time contributing to torchbench so I might be missing basic stuff but I feel like it'd be worth instead making it clearer what folks should do in this case because it's not quite implementing |
Contributor
cclauss
pushed a commit
to cclauss/benchmark
that referenced
this pull request
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One more thing that's bugging me is it's not too clear how to get the tests to pass so will send out another PR soon