Skip to content

Conversation

@samanklesaria
Copy link
Collaborator

Enable CI integration tests.

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 5, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/4092

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit 8b90fdf with merge base 7260d09 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed label Sep 5, 2025
@pearu pearu added this to the 2.9 milestone Sep 5, 2025
@samanklesaria
Copy link
Collaborator Author

Even though CUDA builds should be turned off, we're still getting compiler errors about missing CUDA. I think I should copy the installation strategy of the other CI scripts and use conda rather than the system packages.

@samanklesaria
Copy link
Collaborator Author

samanklesaria commented Sep 5, 2025

The wav2vec2_pipeline_test and rnnt_pipeline_test both read flac assets that get downloaded from "https://download.pytorch.org/torchaudio/". But scipy doesn't allow loading flac files: We get the error " File format b'fLaC' not understood". We really need to use torchcodec for this, not torchaudio. The original reason we had used the scipy hack was because we couldn't get a recent enough ffmpeg version installed on the CI machines. But now that we're completely ignoring the pytorch-infra conda environment and building our own, we might not need to do that. I'll make a separate PR that tries to get the linux unit tests to run without the scipy hack.

@pearu pearu modified the milestones: 2.9, 2.10 Sep 11, 2025
@pearu pearu force-pushed the enable_integration_tests branch from 8f78e90 to 8cc969d Compare September 12, 2025 13:11
@pearu pearu marked this pull request as ready for review September 12, 2025 14:30
@pearu pearu requested a review from a team as a code owner September 12, 2025 14:30
Copy link
Collaborator Author

@samanklesaria samanklesaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@pearu pearu force-pushed the enable_integration_tests branch from dfd0407 to f1cbde9 Compare September 12, 2025 21:03
@pearu pearu self-requested a review September 12, 2025 21:12
Copy link
Collaborator

@pearu pearu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pearu pearu force-pushed the enable_integration_tests branch from f1cbde9 to 8b90fdf Compare September 13, 2025 08:51
@pearu pearu merged commit 87ff22e into main Sep 13, 2025
50 checks passed
@pearu pearu deleted the enable_integration_tests branch September 13, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants