-
Notifications
You must be signed in to change notification settings - Fork 738
Enable integration tests #4092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable integration tests #4092
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/4092
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit 8b90fdf with merge base 7260d09 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Even though CUDA builds should be turned off, we're still getting compiler errors about missing CUDA. I think I should copy the installation strategy of the other CI scripts and use conda rather than the system packages. |
|
The wav2vec2_pipeline_test and rnnt_pipeline_test both read flac assets that get downloaded from "https://download.pytorch.org/torchaudio/". But scipy doesn't allow loading flac files: We get the error " File format b'fLaC' not understood". We really need to use torchcodec for this, not torchaudio. The original reason we had used the scipy hack was because we couldn't get a recent enough ffmpeg version installed on the CI machines. But now that we're completely ignoring the pytorch-infra conda environment and building our own, we might not need to do that. I'll make a separate PR that tries to get the linux unit tests to run without the scipy hack. |
8f78e90 to
8cc969d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
dfd0407 to
f1cbde9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
f1cbde9 to
8b90fdf
Compare
Enable CI integration tests.