Fix vad return zero output when nonzero pre_trigger_time is requested #3866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3866
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D67532573 |
…pytorch#3866) Summary: The `pre_trigger_time` argument is supposed to preserve a certain amount of silence no matter how much silence is detected. Before this fix, passing `pre_trigger_time>0` would still return empty audio when `has_triggered=False`, which is problematic. This fix is backward compatible and addressed this issue. Reviewed By: zsmeditation Differential Revision: D67532573
RoyJames
force-pushed
the
export-D67532573
branch
from
34226aa to
2335a46
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67532573 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D67532573