Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: references for lfilter implementation #3734

Merged
merged 6 commits into from
Jan 25, 2024

Conversation

yoyolicoris
Copy link
Collaborator

Add references to @yoyololicon and @forgi86's works for the core implementation of lfilter.
@forgi86 implemented the same logic as torchaudio's in forgi86/dynonet for efficient backpropagation.

@yoyolicoris yoyolicoris requested a review from mthrok January 23, 2024 18:54
@yoyolicoris yoyolicoris requested a review from a team as a code owner January 23, 2024 18:54
Copy link

pytorch-bot bot commented Jan 23, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3734

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 7be5a28 with merge base b2d9c3e (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Collaborator

@mthrok mthrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Looks good but the linter is failing.

src/torchaudio/functional/filtering.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@mthrok mthrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mthrok
Copy link
Collaborator

mthrok commented Jan 25, 2024

Feel free to merge!

@yoyolicoris yoyolicoris merged commit d5a9433 into pytorch:main Jan 25, 2024
58 of 60 checks passed
@yoyolicoris yoyolicoris deleted the doc/lfilter-reference branch January 25, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants