Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change modality naming inconsistency (visual & video) #3631

Merged
merged 2 commits into from
Oct 3, 2023

Conversation

orena1
Copy link
Contributor

@orena1 orena1 commented Oct 2, 2023

see here: #3629

@orena1 orena1 requested a review from mpc001 as a code owner October 2, 2023 17:48
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 2, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3631

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d8c2479 with merge base b7791ea (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@orena1 orena1 mentioned this pull request Oct 2, 2023
@orena1 orena1 changed the title change visual to video change modality naming inconsistency visual, video Oct 2, 2023
@orena1 orena1 changed the title change modality naming inconsistency visual, video change modality naming inconsistency (visual & video) Oct 2, 2023
@mpc001
Copy link
Contributor

mpc001 commented Oct 3, 2023

LGTM, thanks for the fix

@mpc001 mpc001 enabled auto-merge (squash) October 3, 2023 09:14
@mpc001 mpc001 merged commit 47f502a into pytorch:main Oct 3, 2023
@orena1 orena1 deleted the patch-2 branch October 6, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants