Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove (object) #3597

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Remove (object) #3597

merged 2 commits into from
Sep 29, 2023

Conversation

r-barnes
Copy link
Contributor

@r-barnes r-barnes commented Sep 6, 2023

Summary: Python3 makes the use of (object) in class inheritance unnecessary. Let's modernize our code by eliminating this.

Reviewed By: aaronenyeshi

Differential Revision: D48957872

…cm/tests/L1/common/main_amp.py

Summary: Python3 makes the use of `(object)` in class inheritance unnecessary. Let's modernize our code by eliminating this.

Reviewed By: aaronenyeshi

Differential Revision: D48957872
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 6, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3597

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 2523faa with merge base d07aebf (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48957872

@mthrok
Copy link
Collaborator

mthrok commented Sep 6, 2023

Could you fix the title? @r-barnes

@mthrok mthrok changed the title [codemod] Del (object) from 10 inc pytorch/apex/third-party/apex_rocm/tests/L1/common/main_amp.py Remove (object) Sep 29, 2023
@mthrok mthrok enabled auto-merge (squash) September 29, 2023 15:25
@mthrok mthrok requested a review from nateanl as a code owner September 29, 2023 15:27
@mthrok mthrok merged commit b7791ea into pytorch:main Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants