-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate Release-Only Changes #3590
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3590
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 39756e1 with merge base 5cf7d2d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Although I think this script, as it stands, doesn't need to be on a per-repo basis because replacing branch name is done everywhere. But there might be more audio-specific steps later on I assume
@huydhn Yeah I was wondering something similar. There's nothing inherently audio-specific here, and with how the nova workflows are structured, I don't think there should be anything in the future. We can add such a script in test-infra, but might need to make some assumptions about the domain library setup. On the other hand, we could just make it a GHA, but might be overkill. Decided to just have this in each repo for now, but open to consolidation ideas. |
@osalpekar has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@osalpekar merged this pull request in af79867. |
Hey @osalpekar. Some guidance:Use 'module: ops' for operations under 'torchaudio/{transforms, functional}', and ML-related components under 'torchaudio/csrc' (e.g. RNN-T loss). Things in "examples" directory:
Regarding examples in code documentations, please also use 'module: docs'. Please use 'other' tag only when you’re sure the changes are not much relevant to users, or when all other tags are not applicable. Try not to use it often, in order to minimize efforts required when we prepare release notes. When preparing release notes, please make sure 'documentation' and 'tutorials' occur as the last sub-categories under each primary category like 'new feature', 'improvements' or 'prototype'. Things related to build are by default excluded from the release note, except when it impacts users. For example: |
@osalpekar @huydhn We ususally have release-specific changes, which is removing prototypes #3592. It would be nice that it can be incorporated. |
@mthrok Sure, let me look into doing that. I'm also wondering if there's something safer we could for for handling the prototypes in the release branch - we could make the prototype directory hidden ( |
Utility script to run after branch cut have been completed. Execute: ``RELEASE_VERSION=2.1 apply-release-changes.sh`` Similar to: pytorch/audio#3590 Test PR: #109210 Automate generation of PRs: #108053 #108688 #108064 Pull Request resolved: #109208 Approved by: https://github.com/seemethere
Utility script to run after branch cut have been completed. Execute: ``RELEASE_VERSION=2.1 apply-release-changes.sh`` Similar to: pytorch/audio#3590 Test PR: pytorch#109210 Automate generation of PRs: pytorch#108053 pytorch#108688 pytorch#108064 Pull Request resolved: pytorch#109208 Approved by: https://github.com/seemethere
First Pass for automating release-only changes.
Tested this in audio to ensure it works.