Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate Release-Only Changes #3590

Closed
wants to merge 2 commits into from
Closed

Conversation

osalpekar
Copy link
Member

@osalpekar osalpekar commented Sep 1, 2023

First Pass for automating release-only changes.

Tested this in audio to ensure it works.

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 1, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3590

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 39756e1 with merge base 5cf7d2d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@osalpekar osalpekar requested review from huydhn and atalman September 1, 2023 02:13
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Although I think this script, as it stands, doesn't need to be on a per-repo basis because replacing branch name is done everywhere. But there might be more audio-specific steps later on I assume

@osalpekar
Copy link
Member Author

@huydhn Yeah I was wondering something similar. There's nothing inherently audio-specific here, and with how the nova workflows are structured, I don't think there should be anything in the future. We can add such a script in test-infra, but might need to make some assumptions about the domain library setup. On the other hand, we could just make it a GHA, but might be overkill. Decided to just have this in each repo for now, but open to consolidation ideas.

@facebook-github-bot
Copy link
Contributor

@osalpekar has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@osalpekar merged this pull request in af79867.

@github-actions
Copy link

github-actions bot commented Sep 1, 2023

Hey @osalpekar.
You merged this PR, but labels were not properly added. Please add a primary and secondary label (See https://github.com/pytorch/audio/blob/main/.github/process_commit.py).


Some guidance:

Use 'module: ops' for operations under 'torchaudio/{transforms, functional}', and ML-related components under 'torchaudio/csrc' (e.g. RNN-T loss).

Things in "examples" directory:

  • 'recipe' is applicable to training recipes under the 'examples' folder,
  • 'tutorial' is applicable to tutorials under the “examples/tutorials” folder
  • 'example' is applicable to everything else (e.g. C++ examples)
  • 'module: docs' is applicable to code documentations (not to tutorials).

Regarding examples in code documentations, please also use 'module: docs'.

Please use 'other' tag only when you’re sure the changes are not much relevant to users, or when all other tags are not applicable. Try not to use it often, in order to minimize efforts required when we prepare release notes.


When preparing release notes, please make sure 'documentation' and 'tutorials' occur as the last sub-categories under each primary category like 'new feature', 'improvements' or 'prototype'.

Things related to build are by default excluded from the release note, except when it impacts users. For example:
* Drop support of Python 3.7.
* Add support of Python 3.X.
* Change the way a third party library is bound (so that user needs to install it separately).

@mthrok mthrok deleted the automate_release_changes branch September 5, 2023 15:13
@mthrok
Copy link
Collaborator

mthrok commented Sep 5, 2023

@osalpekar @huydhn We ususally have release-specific changes, which is removing prototypes #3592. It would be nice that it can be incorporated.

@osalpekar
Copy link
Member Author

@mthrok Sure, let me look into doing that. I'm also wondering if there's something safer we could for for handling the prototypes in the release branch - we could make the prototype directory hidden (_prototypes) signaling the underlying components are not to be imported, and we could set a flag on the prototype unittests so that they are not run on the release-branch (or just have a separate CI job for them that doesn't run on the release branch). Let me know what you think!

pytorchmergebot pushed a commit to pytorch/pytorch that referenced this pull request Nov 7, 2023
Utility script to run after branch cut have been completed.
Execute: ``RELEASE_VERSION=2.1 apply-release-changes.sh``
Similar to: pytorch/audio#3590

Test PR: #109210

Automate generation of PRs:
#108053
#108688
#108064

Pull Request resolved: #109208
Approved by: https://github.com/seemethere
Skylion007 pushed a commit to Skylion007/pytorch that referenced this pull request Nov 14, 2023
Utility script to run after branch cut have been completed.
Execute: ``RELEASE_VERSION=2.1 apply-release-changes.sh``
Similar to: pytorch/audio#3590

Test PR: pytorch#109210

Automate generation of PRs:
pytorch#108053
pytorch#108688
pytorch#108064

Pull Request resolved: pytorch#109208
Approved by: https://github.com/seemethere
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants