-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BC-Breaking] Remove legacy global backend switch #3559
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3559
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f5b55b3 with merge base e057d7d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
866013a
to
5cda530
Compare
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This pull request was exported from Phabricator. Differential Revision: D48353764 |
Summary: This PR removes the legacy backend switch mechanism. The implementation itself is still available. Merge after v2.1 release Pull Request resolved: pytorch#3559 Differential Revision: D48353764 Pulled By: mthrok fbshipit-source-id: 73b8955c609a92aee37a5c23a0917403e0a2ca17
5cda530
to
789981b
Compare
Summary: This PR removes the legacy backend switch mechanism. The implementation itself is still available. Merge after v2.1 release Pull Request resolved: pytorch#3559 Differential Revision: D48353764 Pulled By: mthrok fbshipit-source-id: 5cbe66a0409abca4c0ff1a61c6aaf622f47810bb
This pull request was exported from Phabricator. Differential Revision: D48353764 |
789981b
to
f5b55b3
Compare
This pull request was exported from Phabricator. Differential Revision: D48353764 |
3 similar comments
This pull request was exported from Phabricator. Differential Revision: D48353764 |
This pull request was exported from Phabricator. Differential Revision: D48353764 |
This pull request was exported from Phabricator. Differential Revision: D48353764 |
Hey @mthrok. Some guidance:Use 'module: ops' for operations under 'torchaudio/{transforms, functional}', and ML-related components under 'torchaudio/csrc' (e.g. RNN-T loss). Things in "examples" directory:
Regarding examples in code documentations, please also use 'module: docs'. Please use 'other' tag only when you’re sure the changes are not much relevant to users, or when all other tags are not applicable. Try not to use it often, in order to minimize efforts required when we prepare release notes. When preparing release notes, please make sure 'documentation' and 'tutorials' occur as the last sub-categories under each primary category like 'new feature', 'improvements' or 'prototype'. Things related to build are by default excluded from the release note, except when it impacts users. For example: |
This PR removes the legacy backend switch mechanism.
The implementation itself is still available.
Merge after v2.1 release