-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move backend initialization to toplevel #3548
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3548
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 596d383: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
9f03224
to
12089a6
Compare
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
12089a6
to
828e3c6
Compare
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
828e3c6
to
596d383
Compare
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Hey @mthrok. Some guidance:Use 'module: ops' for operations under 'torchaudio/{transforms, functional}', and ML-related components under 'torchaudio/csrc' (e.g. RNN-T loss). Things in "examples" directory:
Regarding examples in code documentations, please also use 'module: docs'. Please use 'other' tag only when you’re sure the changes are not much relevant to users, or when all other tags are not applicable. Try not to use it often, in order to minimize efforts required when we prepare release notes. When preparing release notes, please make sure 'documentation' and 'tutorials' occur as the last sub-categories under each primary category like 'new feature', 'improvements' or 'prototype'. Things related to build are by default excluded from the release note, except when it impacts users. For example: |
The backend dispatcher is implemented in
torchaudio._backend
, while the legacy backend is implemented intorchaudio.backend
.The initialization happen in
torchaudio._backend
.This commit moves it to
torchaudio.__init__
, so thatbackend
and_backend
is more independent.