Refactor compat #3518
Closed
Refactor compat #3518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3518
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New Failures, 3 Unrelated FailuresAs of commit 3ec4cb1: NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base 61cbf79:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
mthrok
force-pushed
the
refactor-compat
branch
4 times, most recently
from
ccdc234 to
f3b5e8a
Compare
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: The I/O functions in _compat module was introduced there so that everything related to FFmpeg is in torchaudio.io and FFmpeg library initialization can be carried out in `torchaudio.io.__init__`. Now that this constraint is removed, (all the initialization happens at `torchaudio._extension.__init__`) and `_compat` is only used by FFmpeg dispatcher backend, we move the module to `torchaudio._backend` for better locality. Pull Request resolved: pytorch#3518 Reviewed By: huangruizhe Differential Revision: D47877412 Pulled By: mthrok fbshipit-source-id: 24b93a2ede52e77809198bda8eb9edb94f19dae7
|
This pull request was exported from Phabricator. Differential Revision: D47877412 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The I/O functions in _compat module was introduced there so that
everything related to FFmpeg is in torchaudio.io and FFmpeg library
initialization can be carried out in
torchaudio.io.__init__.Now that this constraint is removed, (all the initialization happens
at
torchaudio._extension.__init__) and_compatis only used byFFmpeg dispatcher backend, we move the module to
torchaudio._backendfor better locality.