-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux CPU job should respect set Python version #3477
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3477
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 158894c: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@osalpekar has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Looks good on Linux side https://github.com/pytorch/audio/actions/runs/5536182084/jobs/10103496032?pr=3477#step:10:6890 However, now the macOS job seems to be failing due to this change... https://github.com/pytorch/audio/actions/runs/5536182078/jobs/10103495640 Do you have an idea why? I wonder if macOS image has conda installed in a different location than this
|
@osalpekar has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful. Thank you!
@osalpekar merged this pull request in 86cb1e0. |
Hey @osalpekar. Some guidance:Use 'module: ops' for operations under 'torchaudio/{transforms, functional}', and ML-related components under 'torchaudio/csrc' (e.g. RNN-T loss). Things in "examples" directory:
Regarding examples in code documentations, please also use 'module: docs'. Please use 'other' tag only when you’re sure the changes are not much relevant to users, or when all other tags are not applicable. Try not to use it often, in order to minimize efforts required when we prepare release notes. When preparing release notes, please make sure 'documentation' and 'tutorials' occur as the last sub-categories under each primary category like 'new feature', 'improvements' or 'prototype'. Things related to build are by default excluded from the release note, except when it impacts users. For example: |
Reintroduce a conda environment within which we will do all deps installation, audio builds, and tests runs. This conda environment will use the python version set by the GHA job - previously this just defaulted to using the system 3.10 python which was default inside the container.