Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package smoke test #3465

Closed
wants to merge 3 commits into from
Closed

Update package smoke test #3465

wants to merge 3 commits into from

Conversation

mthrok
Copy link
Collaborator

@mthrok mthrok commented Jul 10, 2023

  1. Update smoke test script to change directory so that there is no torchaudio directory in CWD when smoke test is being executed.
  2. Disable the part of smoke test which requires FFmpeg for wheel. The preparation for Remove special cases for torchaudio FFmpeg test-infra#4358

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 10, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3465

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures

As of commit 8a76e41:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@mthrok mthrok changed the title Smoke test Update package smoke test Jul 10, 2023
@mthrok mthrok marked this pull request as ready for review July 10, 2023 19:21
@@ -36,7 +36,7 @@ jobs:
cache-key: macos-ffmpeg
pre-script: packaging/pre_build_script.sh
post-script: packaging/post_build_script.sh
smoke-test-script: test/smoke_test/smoke_test.py
smoke-test-script: test/smoke_test/smoke_test_no_ffmpeg.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be test/smoke_test/smoke_test.py --no-ffmpeg instead?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comment

@facebook-github-bot
Copy link
Contributor

@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@mthrok merged this pull request in 589de10.

@github-actions
Copy link

Hey @mthrok.
You merged this PR, but labels were not properly added. Please add a primary and secondary label (See https://github.com/pytorch/audio/blob/main/.github/process_commit.py).


Some guidance:

Use 'module: ops' for operations under 'torchaudio/{transforms, functional}', and ML-related components under 'torchaudio/csrc' (e.g. RNN-T loss).

Things in "examples" directory:

  • 'recipe' is applicable to training recipes under the 'examples' folder,
  • 'tutorial' is applicable to tutorials under the “examples/tutorials” folder
  • 'example' is applicable to everything else (e.g. C++ examples)
  • 'module: docs' is applicable to code documentations (not to tutorials).

Regarding examples in code documentations, please also use 'module: docs'.

Please use 'other' tag only when you’re sure the changes are not much relevant to users, or when all other tags are not applicable. Try not to use it often, in order to minimize efforts required when we prepare release notes.


When preparing release notes, please make sure 'documentation' and 'tutorials' occur as the last sub-categories under each primary category like 'new feature', 'improvements' or 'prototype'.

Things related to build are by default excluded from the release note, except when it impacts users. For example:
* Drop support of Python 3.7.
* Add support of Python 3.X.
* Change the way a third party library is bound (so that user needs to install it separately).

@mthrok mthrok added the other label Jul 11, 2023
@mthrok mthrok deleted the smoke-test branch July 11, 2023 10:09
atalman pushed a commit to pytorch/test-infra that referenced this pull request Jul 11, 2023
This commit removes all the code related to FFmpeg, which are specific
to torchaudio.

pytorch/audio#3460 changed the way torchaudio is
built. FFmpeg integration is handled automatically and enabled by
default. This eliminates the need to supply FFmepg externally.
test-infra no longer needs to build FFmpeg and use pre/post-scripts for
torchaudio.

Note that smoke test was updated in
pytorch/audio#3465 to not use FFmpeg for wheel.
We will revisit this later with multiple FFmpeg version support.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants