-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update package smoke test #3465
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3465
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New FailuresAs of commit 8a76e41: NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@@ -36,7 +36,7 @@ jobs: | |||
cache-key: macos-ffmpeg | |||
pre-script: packaging/pre_build_script.sh | |||
post-script: packaging/post_build_script.sh | |||
smoke-test-script: test/smoke_test/smoke_test.py | |||
smoke-test-script: test/smoke_test/smoke_test_no_ffmpeg.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be test/smoke_test/smoke_test.py --no-ffmpeg
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that you cannot pass an argument
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see comment
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Hey @mthrok. Some guidance:Use 'module: ops' for operations under 'torchaudio/{transforms, functional}', and ML-related components under 'torchaudio/csrc' (e.g. RNN-T loss). Things in "examples" directory:
Regarding examples in code documentations, please also use 'module: docs'. Please use 'other' tag only when you’re sure the changes are not much relevant to users, or when all other tags are not applicable. Try not to use it often, in order to minimize efforts required when we prepare release notes. When preparing release notes, please make sure 'documentation' and 'tutorials' occur as the last sub-categories under each primary category like 'new feature', 'improvements' or 'prototype'. Things related to build are by default excluded from the release note, except when it impacts users. For example: |
This commit removes all the code related to FFmpeg, which are specific to torchaudio. pytorch/audio#3460 changed the way torchaudio is built. FFmpeg integration is handled automatically and enabled by default. This eliminates the need to supply FFmepg externally. test-infra no longer needs to build FFmpeg and use pre/post-scripts for torchaudio. Note that smoke test was updated in pytorch/audio#3465 to not use FFmpeg for wheel. We will revisit this later with multiple FFmpeg version support.
torchaudio
directory in CWD when smoke test is being executed.