Support multiple FFmpeg versions #3464
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3464
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 New FailuresAs of commit dba6158: NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Pull Request resolved: pytorch#3464 Differential Revision: D47300223 Pulled By: mthrok fbshipit-source-id: b9562a0597f79d7feb6d3bf9172754610b01b39f
|
This pull request was exported from Phabricator. Differential Revision: D47300223 |
Summary: Pull Request resolved: pytorch#3464 Differential Revision: D47300223 Pulled By: mthrok fbshipit-source-id: 0fef04461478402a457a537ce9bd6f68c54b02ab
|
This pull request was exported from Phabricator. Differential Revision: D47300223 |
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Pull Request resolved: pytorch#3464 Differential Revision: D47300223 Pulled By: mthrok fbshipit-source-id: 0fef04461478402a457a537ce9bd6f68c54b02ab
Summary: Pull Request resolved: pytorch#3464 Differential Revision: D47300223 Pulled By: mthrok fbshipit-source-id: 0fef04461478402a457a537ce9bd6f68c54b02ab
Summary: Pull Request resolved: pytorch#3464 Differential Revision: D47300223 Pulled By: mthrok fbshipit-source-id: 0fef04461478402a457a537ce9bd6f68c54b02ab
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Pull Request resolved: pytorch#3464 Differential Revision: D47300223 Pulled By: mthrok fbshipit-source-id: 0fef04461478402a457a537ce9bd6f68c54b02ab
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Pull Request resolved: pytorch#3464 Differential Revision: D47300223 Pulled By: mthrok fbshipit-source-id: 0fef04461478402a457a537ce9bd6f68c54b02ab
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Pull Request resolved: pytorch#3464 Differential Revision: D47300223 Pulled By: mthrok fbshipit-source-id: 0fef04461478402a457a537ce9bd6f68c54b02ab
Summary: Pull Request resolved: pytorch#3464 Differential Revision: D47300223 Pulled By: mthrok fbshipit-source-id: 0fef04461478402a457a537ce9bd6f68c54b02ab
Summary: This commit introduces support for multiple FFmpeg versions for OSS binary distributions. Currently torchaudio only works with FFmpeg 4. This is inconvenient for users from installing to runtime linking. This commit allows to pick FFmpeg 4, 5 or 6 at runtime, instead of just v4. The way it works is that we compile the FFmpeg extension three times with different FFmpeg. At runtime, we look for libavutil of specific version and when one is found, load the corresponding FFmpeg extension. The look up order is is 6, 5, then 4. To make the build process simple and reproducible, we use pre-built binaries of FFmpeg during the build. They are LGPL and downloaded from S3 at build time, instead of building every time. The use of pre-built binaries as scaffolding limits the system that can build torchaudio, so it also introduces single FFmpeg version support mode. setting FFMPEG_ROOT during the build will change the way binaries are built so that it will only support one specific version of FFmpeg. Pull Request resolved: pytorch#3464 Differential Revision: D47300223 Pulled By: mthrok fbshipit-source-id: 0fef04461478402a457a537ce9bd6f68c54b02ab
Summary: This commit introduces support for multiple FFmpeg versions for OSS binary distributions. Currently torchaudio only works with FFmpeg 4. This is inconvenient for users from installing to runtime linking. This commit allows to pick FFmpeg 4, 5 or 6 at runtime, instead of just v4. The way it works is that we compile the FFmpeg extension three times with different FFmpeg. At runtime, we look for libavutil of specific version and when one is found, load the corresponding FFmpeg extension. The look up order is is 6, 5, then 4. To make the build process simple and reproducible, we use pre-built binaries of FFmpeg during the build. They are LGPL and downloaded from S3 at build time, instead of building every time. The use of pre-built binaries as scaffolding limits the system that can build torchaudio, so it also introduces single FFmpeg version support mode. setting FFMPEG_ROOT during the build will change the way binaries are built so that it will only support one specific version of FFmpeg. Pull Request resolved: pytorch#3464 Differential Revision: D47300223 Pulled By: mthrok fbshipit-source-id: 0fef04461478402a457a537ce9bd6f68c54b02ab
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: This commit introduces support for multiple FFmpeg versions for OSS binary distributions. Currently torchaudio only works with FFmpeg 4. This is inconvenient for users from installing to runtime linking. This commit allows to pick FFmpeg 4, 5 or 6 at runtime, instead of just v4. The way it works is that we compile the FFmpeg extension three times with different FFmpeg. At runtime, we look for libavutil of specific version and when one is found, load the corresponding FFmpeg extension. The look up order is is 6, 5, then 4. To make the build process simple and reproducible, we use pre-built binaries of FFmpeg during the build. They are LGPL and downloaded from S3 at build time, instead of building every time. The use of pre-built binaries as scaffolding limits the system that can build torchaudio, so it also introduces single FFmpeg version support mode. setting FFMPEG_ROOT during the build will change the way binaries are built so that it will only support one specific version of FFmpeg. Pull Request resolved: pytorch#3464 Differential Revision: D47300223 Pulled By: mthrok fbshipit-source-id: 0fef04461478402a457a537ce9bd6f68c54b02ab
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: This commit introduces support for multiple FFmpeg versions for OSS binary distributions. Currently torchaudio only works with FFmpeg 4. This is inconvenient for users from installing to runtime linking. This commit allows to pick FFmpeg 4, 5 or 6 at runtime, instead of just v4. The way it works is that we compile the FFmpeg extension three times with different FFmpeg. At runtime, we look for libavutil of specific version and when one is found, load the corresponding FFmpeg extension. The look up order is is 6, 5, then 4. To make the build process simple and reproducible, we use pre-built binaries of FFmpeg during the build. They are LGPL and downloaded from S3 at build time, instead of building every time. The use of pre-built binaries as scaffolding limits the system that can build torchaudio, so it also introduces single FFmpeg version support mode. setting FFMPEG_ROOT during the build will change the way binaries are built so that it will only support one specific version of FFmpeg. Pull Request resolved: pytorch#3464 Differential Revision: D47300223 Pulled By: mthrok fbshipit-source-id: 0fef04461478402a457a537ce9bd6f68c54b02ab
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Hey @mthrok. Some guidance:Use 'module: ops' for operations under 'torchaudio/{transforms, functional}', and ML-related components under 'torchaudio/csrc' (e.g. RNN-T loss). Things in "examples" directory:
Regarding examples in code documentations, please also use 'module: docs'. Please use 'other' tag only when you’re sure the changes are not much relevant to users, or when all other tags are not applicable. Try not to use it often, in order to minimize efforts required when we prepare release notes. When preparing release notes, please make sure 'documentation' and 'tutorials' occur as the last sub-categories under each primary category like 'new feature', 'improvements' or 'prototype'. Things related to build are by default excluded from the release note, except when it impacts users. For example: |
This commit introduces support for multiple FFmpeg versions for OSS binary distributions.
Currently torchaudio only works with FFmpeg 4. This is inconvenient from installing to runtime linking.
This commit allows to pick FFmpeg 4, 5 or 6 at runtime, instead of just looking for v4.
The way it works is that we compile the FFmpeg extension three times with different FFmpeg and ship them.
At runtime, we look for libavutil of specific version and when one is found, load the corresponding FFmpeg extension.
The order of preference is 6, 5, then 4.
To make the build process simple and reproducible, we use pre-built binaries of FFmpeg during the build.
They are LGPL and downloaded from S3 at build time, instead of building every time.
The use of pre-built binaries as scaffolding limits the system that can build torchaudio, so it also introduces
single FFmpeg version support mode. setting FFMPEG_ROOT during the build will change the way binaries are built
so that it will only support one specific version of FFmpeg.