-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split the CTC forced aligment API tutorial into two tutorials #3443
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3443
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New FailuresAs of commit 55fc478: NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@xiaohui-zhang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@xiaohui-zhang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
examples/tutorials/forced_alignment_for_multilingual_data_tutorial.py
Outdated
Show resolved
Hide resolved
examples/tutorials/forced_alignment_for_multilingual_data_tutorial.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to see a lot more languages than just two.
will add more languages |
@xiaohui-zhang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
addressed comments |
examples/tutorials/forced_alignment_for_multilingual_data_tutorial.py
Outdated
Show resolved
Hide resolved
examples/tutorials/forced_alignment_for_multilingual_data_tutorial.py
Outdated
Show resolved
Hide resolved
examples/tutorials/forced_alignment_for_multilingual_data_tutorial.py
Outdated
Show resolved
Hide resolved
examples/tutorials/forced_alignment_for_multilingual_data_tutorial.py
Outdated
Show resolved
Hide resolved
examples/tutorials/forced_alignment_for_multilingual_data_tutorial.py
Outdated
Show resolved
Hide resolved
examples/tutorials/forced_alignment_for_multilingual_data_tutorial.py
Outdated
Show resolved
Hide resolved
examples/tutorials/forced_alignment_for_multilingual_data_tutorial.py
Outdated
Show resolved
Hide resolved
examples/tutorials/forced_alignment_for_multilingual_data_tutorial.py
Outdated
Show resolved
Hide resolved
examples/tutorials/forced_alignment_for_multilingual_data_tutorial.py
Outdated
Show resolved
Hide resolved
examples/tutorials/forced_alignment_for_multilingual_data_tutorial.py
Outdated
Show resolved
Hide resolved
examples/tutorials/forced_alignment_for_multilingual_data_tutorial.py
Outdated
Show resolved
Hide resolved
examples/tutorials/forced_alignment_for_multilingual_data_tutorial.py
Outdated
Show resolved
Hide resolved
@xiaohui-zhang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@xiaohui-zhang merged this pull request in 627c37a. |
Hey @xiaohui-zhang. Some guidance:Use 'module: ops' for operations under 'torchaudio/{transforms, functional}', and ML-related components under 'torchaudio/csrc' (e.g. RNN-T loss). Things in "examples" directory:
Regarding examples in code documentations, please also use 'module: docs'. Please use 'other' tag only when you’re sure the changes are not much relevant to users, or when all other tags are not applicable. Try not to use it often, in order to minimize efforts required when we prepare release notes. When preparing release notes, please make sure 'documentation' and 'tutorials' occur as the last sub-categories under each primary category like 'new feature', 'improvements' or 'prototype'. Things related to build are by default excluded from the release note, except when it impacts users. For example: |
Splitting the multilingual example part into another tutorial.