-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the input pixel format when using GPU video encoder #3426
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3426
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 12 Pending, 1 Unrelated FailureAs of commit d8cdced: BROKEN TRUNK - The following job failed but were present on the merge base a7fea8a:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
StreamWriter's encoding pipeline looks like the following 1. convert tensor to AVFrame 2. pass AVFrame to AVFilter 3. pass the resulting AVFrame to AVCodecContext (encoder) and AVFormatContext (muxer) When dealing with CUDA tensor, the AVFilter becomes no-op, as we have not added support for CUDA-compatible filters. When CUDA frame is passed, the existing solution passes the software pixel format to AVFilter, which issues warning later as what AVFilter sees is AV_PIX_FMT_CUDA. Since the filter itself is no-op, it functions as expected. But this commit fixes it.
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Hey @mthrok. Some guidance:Use 'module: ops' for operations under 'torchaudio/{transforms, functional}', and ML-related components under 'torchaudio/csrc' (e.g. RNN-T loss). Things in "examples" directory:
Regarding examples in code documentations, please also use 'module: docs'. Please use 'other' tag only when you’re sure the changes are not much relevant to users, or when all other tags are not applicable. Try not to use it often, in order to minimize efforts required when we prepare release notes. When preparing release notes, please make sure 'documentation' and 'tutorials' occur as the last sub-categories under each primary category like 'new feature', 'improvements' or 'prototype'. Things related to build are by default excluded from the release note, except when it impacts users. For example: |
StreamWriter's encoding pipeline looks like the following
When dealing with CUDA tensor, the AVFilter becomes no-op, as we have not added support for CUDA-compatible filters.
When CUDA frame is passed, the existing solution passes the software pixel format to AVFilter, which issues warning later as what AVFilter sees is AV_PIX_FMT_CUDA.
Since the filter itself is no-op, it functions as expected. But this commit fixes it.
See #3317