-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete CCI Linux and MacOS Unittest Jobs #3391
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3391
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 New FailuresAs of commit 720543d: NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Though technically I think deletion is a better description than deprecation.
@osalpekar has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
c7de0a2
to
10498b7
Compare
@osalpekar has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@osalpekar has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@osalpekar merged this pull request in d5d94b7. |
Hey @osalpekar. Some guidance:Use 'module: ops' for operations under 'torchaudio/{transforms, functional}', and ML-related components under 'torchaudio/csrc' (e.g. RNN-T loss). Things in "examples" directory:
Please use 'other' tag only when you’re sure the changes are not much relevant to users, or when all other tags are not applicable. Try not to use it often, in order to minimize efforts required when we prepare release notes. When preparing release notes, please make sure 'documentation' and 'tutorials' occur as the last sub-categories under each primary category like 'new feature', 'improvements' or 'prototype'. Things related to build are by default excluded from the release note, except when it impacts users. For example: |
Deprecates the Linux and MacOS Unittest jobs now that they've been running on Nova for over a week.
Aside: There was also a stylecheck job that was dependent on the Linux Unittest job. I also put up #3390 to move that stylecheck job to Nova. I'm happy to reintroduce the CCI stylecheck job standalone in CCI if we want the Nova version to run on main for a week.