Update and deprecate apply_codec function #3386
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3386
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New FailuresAs of commit 688661d: NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
mthrok
force-pushed
the
apply-codec
branch
4 times, most recently
from
ba49661 to
0410f2b
Compare
mthrok
changed the title
mthrok
changed the title
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
hwangjeff
approved these changes
May 31, 2023
To prepare for the upcoming removal of file-like object support from sox_io backend, this commit changes apply_codec function to use tempfile. `apply_codec` function is now deprecated and users are encourated to use `torchaudio.io.AudioEffector`. We will not remove the function itself, but will remove the entry from the doc.
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Jun 1, 2023
Follow-up pytorch#3386 The intended change was to use path of temporary file, instead of file-like object
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Jun 1, 2023
Follow-up pytorch#3386 The intended change was to use path of temporary file, instead of file-like object
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Jun 1, 2023
Summary: Follow-up pytorch#3386 The intended change was to use path of temporary file, instead of file-like object Pull Request resolved: pytorch#3397 Reviewed By: hwangjeff Differential Revision: D46346189 Pulled By: mthrok fbshipit-source-id: e6bd30c6d749afb0b7505a2955cfac732d0b76f5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prepare for the upcoming removal of file-like object support from sox_io backend,
this commit changes apply_codec function to use tempfile.
apply_codecfunction is now deprecated and users are encourated to usetorchaudio.io.AudioEffector.We will not remove the function itself, but will remove the entry from the doc.