Fix saving mp3 with FFmpeg backend #3385
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Encoder name must be libmp3lame when saving mp3.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3385
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 128f65b: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
May 30, 2023
When dealing with vorbis format, FFmpeg expects "ogg" container/extension with "vorbis" encoder. It does not recognize "vorbis" container/extension. libsox-based torchaudio I/O used to handle vorbis extension. This commit refactors the internal of save argument and adds support to vorbis as extension for those cases with FFmpeg backend. This also fixes the case of mp3 pytorch#3385
|
Superseded by #3387 |
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
May 30, 2023
When dealing with vorbis format, FFmpeg expects "ogg" container/extension with "vorbis" encoder. It does not recognize "vorbis" container/extension. libsox-based torchaudio I/O used to handle vorbis extension. This commit refactors the internal of save argument and adds support to vorbis as extension for those cases with FFmpeg backend. This also fixes the case of mp3 pytorch#3385
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
May 31, 2023
When dealing with vorbis format, FFmpeg expects "ogg" container/extension with "vorbis" encoder. It does not recognize "vorbis" container/extension. libsox-based torchaudio I/O used to handle vorbis extension. This commit refactors the internal of save argument and adds support to vorbis as extension for those cases with FFmpeg backend. This also fixes the case of mp3 pytorch#3385
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
May 31, 2023
When dealing with vorbis format, FFmpeg expects "ogg" container/extension with "vorbis" encoder. It does not recognize "vorbis" container/extension. libsox-based torchaudio I/O used to handle vorbis extension. This commit refactors the internal of save argument and adds support to vorbis as extension for those cases with FFmpeg backend. This also fixes the case of mp3 pytorch#3385
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encoder name must be libmp3lame when saving mp3.