Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update forced_align method to only support batch Tensors #3365

Closed
wants to merge 1 commit into from

Conversation

nateanl
Copy link
Member

@nateanl nateanl commented May 23, 2023

Summary: Current design of forced_align accepts 2D Tensor for log_probs and 1D Tensor for targets. To make the API simple, the PR make changes to only support batch Tensors (3D Tensor for log_probs and 2D Tensor for targets).

Differential Revision: D46126226

@pytorch-bot
Copy link

pytorch-bot bot commented May 23, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3365

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures

As of commit badb8d3:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46126226

nateanl added a commit to nateanl/audio that referenced this pull request May 24, 2023
Summary:
Pull Request resolved: pytorch#3365

Current design of forced_align accept 2D Tensor for `log_probs` and 1D Tensor for `targets`. To make the API simple, the PR make changes to only support batch Tensors (3D Tensor for `log_probs` and 2D Tensor for `targets`).

Differential Revision: D46126226

fbshipit-source-id: ab53e22b3681d1c1947c632a2df1c99c86f0d0fe
@nateanl nateanl force-pushed the export-D46126226 branch from e951e96 to 28fb238 Compare May 24, 2023 02:22
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46126226

nateanl added a commit to nateanl/audio that referenced this pull request May 24, 2023
Summary:
Pull Request resolved: pytorch#3365

Current design of forced_align accept 2D Tensor for `log_probs` and 1D Tensor for `targets`. To make the API simple, the PR make changes to only support batch Tensors (3D Tensor for `log_probs` and 2D Tensor for `targets`).

Differential Revision: D46126226

fbshipit-source-id: 51a214252dc91ecee1f82c49f1c4c2861206aad1
@nateanl nateanl force-pushed the export-D46126226 branch from 28fb238 to 0b68e61 Compare May 24, 2023 02:30
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46126226

@nateanl nateanl force-pushed the export-D46126226 branch from 0b68e61 to eb33409 Compare June 5, 2023 20:30
nateanl added a commit to nateanl/audio that referenced this pull request Jun 5, 2023
Summary:
Pull Request resolved: pytorch#3365

Current design of forced_align accept 2D Tensor for `log_probs` and 1D Tensor for `targets`. To make the API simple, the PR make changes to only support batch Tensors (3D Tensor for `log_probs` and 2D Tensor for `targets`).

Reviewed By: vineelpratap

Differential Revision: D46126226

fbshipit-source-id: 2afea56dea853e5c0829ea7f654a57efd55c1712
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46126226

Summary:
Pull Request resolved: pytorch#3365

Current design of forced_align accept 2D Tensor for `log_probs` and 1D Tensor for `targets`. To make the API simple, the PR make changes to only support batch Tensors (3D Tensor for `log_probs` and 2D Tensor for `targets`).

Reviewed By: vineelpratap

Differential Revision: D46126226

fbshipit-source-id: 2380ed14090909a3cbf1f987363ac01173c24782
@nateanl nateanl force-pushed the export-D46126226 branch from eb33409 to badb8d3 Compare June 5, 2023 20:40
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46126226

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 5f17d81.

@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Hey @None.
You merged this PR, but labels were not properly added. Please add a primary and secondary label (See https://github.com/pytorch/audio/blob/main/.github/process_commit.py).


Some guidance:

Use 'module: ops' for operations under 'torchaudio/{transforms, functional}', and ML-related components under 'torchaudio/csrc' (e.g. RNN-T loss).

Things in "examples" directory:

  • 'recipe' is applicable to training recipes under the 'examples' folder,
  • 'tutorial' is applicable to tutorials under the “examples/tutorials” folder
  • 'example' is applicable to everything else (e.g. C++ examples)
  • 'module: docs' is applicable to code documentations (not to tutorials).
    Regarding examples in code documentations, please also use 'module: docs'.

Please use 'other' tag only when you’re sure the changes are not much relevant to users, or when all other tags are not applicable. Try not to use it often, in order to minimize efforts required when we prepare release notes.


When preparing release notes, please make sure 'documentation' and 'tutorials' occur as the last sub-categories under each primary category like 'new feature', 'improvements' or 'prototype'.

Things related to build are by default excluded from the release note, except when it impacts users. For example:
* Drop support of Python 3.7.
* Add support of Python 3.X.
* Change the way a third party library is bound (so that user needs to install it separately).

@facebook-github-bot
Copy link
Contributor

This pull request has been reverted by bbc13b9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants