Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nova] Windows CPU Unittests on Nova #3329

Closed
wants to merge 14 commits into from

Conversation

osalpekar
Copy link
Member

@osalpekar osalpekar commented May 11, 2023

Continuing with the job migrations from CCI to Nova, this PR introduces the Windows CPU Unittest job as a Nova workflow.

The job is passing: https://github.com/pytorch/audio/actions/runs/5094569687/jobs/9159020192?pr=3329.

@pytorch-bot
Copy link

pytorch-bot bot commented May 11, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3329

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 5c0a764:

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@osalpekar osalpekar force-pushed the windows_cpu_nova branch 3 times, most recently from 2ff2025 to 2f7a80e Compare May 16, 2023 22:43
@@ -43,6 +43,9 @@ if [ ! -z "${CUDA_VERSION:-}" ] ; then
fi

# 2. Install torchaudio
printf "* Installing fsspec\n"
pip install --trusted-host pypi.org --trusted-host files.pythonhosted.org fsspec
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: Which dependency requires this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pytorch-lightning depends on fsspec. Installing pytorch-lightning fails on windows in the GHA env due to SSL cert issues, but this fixes the issue.

export TORCHAUDIO_TEST_ALLOW_SKIP_IF_NO_AUDIO_OUT_DEVICE="1"
export TORCHAUDIO_TEST_ALLOW_SKIP_IF_NO_MACOS="1"

# kenlm wheels builds have been broken on Windows for quite some time.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's more useful to mention why it was broken.
And the reason is because somehow compiling KenLm on Windows stopped working for a part that is not changed for 10 years.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the added context - I'll append this comment

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fixes in #3378 and #3381 made the unittests work on trunk again with kenlm. I brought this dependency back in the Nova job as well.

@osalpekar osalpekar changed the title [Nova] Windows Unittests on Nova [Nova] Windows CPU Unittests on Nova May 26, 2023
@osalpekar osalpekar marked this pull request as ready for review May 26, 2023 22:22
@osalpekar
Copy link
Member Author

@osalpekar osalpekar requested a review from mthrok May 26, 2023 22:22
@facebook-github-bot
Copy link
Contributor

@atalman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@atalman merged this pull request in 6425d46.

@github-actions
Copy link

Hey @atalman.
You merged this PR, but labels were not properly added. Please add a primary and secondary label (See https://github.com/pytorch/audio/blob/main/.github/process_commit.py).


Some guidance:

Use 'module: ops' for operations under 'torchaudio/{transforms, functional}', and ML-related components under 'torchaudio/csrc' (e.g. RNN-T loss).

Things in "examples" directory:

  • 'recipe' is applicable to training recipes under the 'examples' folder,
  • 'tutorial' is applicable to tutorials under the “examples/tutorials” folder
  • 'example' is applicable to everything else (e.g. C++ examples)
  • 'module: docs' is applicable to code documentations (not to tutorials).
    Regarding examples in code documentations, please also use 'module: docs'.

Please use 'other' tag only when you’re sure the changes are not much relevant to users, or when all other tags are not applicable. Try not to use it often, in order to minimize efforts required when we prepare release notes.


When preparing release notes, please make sure 'documentation' and 'tutorials' occur as the last sub-categories under each primary category like 'new feature', 'improvements' or 'prototype'.

Things related to build are by default excluded from the release note, except when it impacts users. For example:
* Drop support of Python 3.7.
* Add support of Python 3.X.
* Change the way a third party library is bound (so that user needs to install it separately).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants