-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Nova] Windows CPU Unittests on Nova #3329
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3329
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 5c0a764: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
2ff2025
to
2f7a80e
Compare
@@ -43,6 +43,9 @@ if [ ! -z "${CUDA_VERSION:-}" ] ; then | |||
fi | |||
|
|||
# 2. Install torchaudio | |||
printf "* Installing fsspec\n" | |||
pip install --trusted-host pypi.org --trusted-host files.pythonhosted.org fsspec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: Which dependency requires this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pytorch-lightning
depends on fsspec. Installing pytorch-lightning
fails on windows in the GHA env due to SSL cert issues, but this fixes the issue.
export TORCHAUDIO_TEST_ALLOW_SKIP_IF_NO_AUDIO_OUT_DEVICE="1" | ||
export TORCHAUDIO_TEST_ALLOW_SKIP_IF_NO_MACOS="1" | ||
|
||
# kenlm wheels builds have been broken on Windows for quite some time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's more useful to mention why it was broken.
And the reason is because somehow compiling KenLm on Windows stopped working for a part that is not changed for 10 years.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the added context - I'll append this comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a27fa1a
to
5c0a764
Compare
@atalman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Hey @atalman. Some guidance:Use 'module: ops' for operations under 'torchaudio/{transforms, functional}', and ML-related components under 'torchaudio/csrc' (e.g. RNN-T loss). Things in "examples" directory:
Please use 'other' tag only when you’re sure the changes are not much relevant to users, or when all other tags are not applicable. Try not to use it often, in order to minimize efforts required when we prepare release notes. When preparing release notes, please make sure 'documentation' and 'tutorials' occur as the last sub-categories under each primary category like 'new feature', 'improvements' or 'prototype'. Things related to build are by default excluded from the release note, except when it impacts users. For example: |
Continuing with the job migrations from CCI to Nova, this PR introduces the Windows CPU Unittest job as a Nova workflow.
The job is passing: https://github.com/pytorch/audio/actions/runs/5094569687/jobs/9159020192?pr=3329.