Add Ray tracing method for RIR #2850
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nateanl
reviewed
Nov 16, 2022
test/torchaudio_unittest/prototype/functional/autograd_test_impl.py
Outdated
Show resolved
Hide resolved
| sound_speed: float = 343, | ||
| energy_thres: float = 1e-7, | ||
| time_thres: float = 10, # 10s | ||
| hist_bin_size: float = 0.004, # 4ms |
There was a problem hiding this comment.
we can also add air_absorption as the input argument.
There was a problem hiding this comment.
Should the air_absorption parameter be part of the more global simulate_rir_[hybrid]() function? From what I understand in PRA it is used here https://github.com/LCAV/pyroomacoustics/blob/b3e36a6451e25bc700bc723e6d267645d43ac10f/pyroomacoustics/room.py#LL2331C2-L2331C3, i.e. it does not impact how the energy histogram is computed?
…s but needs cleaning
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Sep 19, 2023
Summary: Revamped version of pytorch#3234 (which was also revamp of pytorch#2850) Differential Revision: D49197174
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Sep 21, 2023
Summary: Revamped version of pytorch#3234 (which was also revamp of pytorch#2850) Differential Revision: D49197174 Pulled By: mthrok
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Oct 2, 2023
Summary: Revamped version of pytorch#3234 (which was also revamp of pytorch#2850) Differential Revision: D49197174 Pulled By: mthrok
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Oct 2, 2023
Summary: Revamped version of pytorch#3234 (which was also revamp of pytorch#2850) Differential Revision: D49197174 Pulled By: mthrok
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Oct 2, 2023
Summary: Revamped version of pytorch#3234 (which was also revamp of pytorch#2850) Differential Revision: D49197174 Pulled By: mthrok
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Oct 2, 2023
Summary: Revamped version of pytorch#3234 (which was also revamp of pytorch#2850) Differential Revision: D49197174 Pulled By: mthrok
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Oct 2, 2023
Summary: Revamped version of pytorch#3234 (which was also revamp of pytorch#2850) Differential Revision: D49197174 Pulled By: mthrok
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Oct 3, 2023
Summary: Revamped version of pytorch#3234 (which was also revamp of pytorch#2850) Differential Revision: D49197174 Pulled By: mthrok
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Oct 3, 2023
Summary: Revamped version of pytorch#3234 (which was also revamp of pytorch#2850) Differential Revision: D49197174 Pulled By: mthrok
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Oct 3, 2023
Summary: Revamped version of pytorch#3234 (which was also revamp of pytorch#2850) Differential Revision: D49197174 Pulled By: mthrok
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Oct 3, 2023
Summary: Revamped version of pytorch#3234 (which was also revamp of pytorch#2850) Differential Revision: D49197174 Pulled By: mthrok
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Oct 3, 2023
Summary: Revamped version of pytorch#3234 (which was also revamp of pytorch#2850) Differential Revision: D49197174 Pulled By: mthrok
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Oct 3, 2023
Summary: Revamped version of pytorch#3234 (which was also revamp of pytorch#2850) Differential Revision: D49197174 Pulled By: mthrok
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Oct 4, 2023
Summary: Revamped version of pytorch#3234 (which was also revamp of pytorch#2850) Differential Revision: D49197174 Pulled By: mthrok
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Oct 4, 2023
Summary: Revamped version of pytorch#3234 (which was also revamp of pytorch#2850) Differential Revision: D49197174 Pulled By: mthrok
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Oct 4, 2023
Summary: Revamped version of pytorch#3234 (which was also revamp of pytorch#2850) Differential Revision: D49197174 Pulled By: mthrok
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Oct 4, 2023
Summary: Revamped version of pytorch#3234 (which was also revamp of pytorch#2850) Differential Revision: D49197174 Pulled By: mthrok
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Oct 5, 2023
Summary: Revamped version of pytorch#3234 (which was also revamp of pytorch#2850) Differential Revision: D49197174 Pulled By: mthrok
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Oct 5, 2023
Summary: Revamped version of pytorch#3234 (which was also revamp of pytorch#2850) Differential Revision: D49197174 Pulled By: mthrok
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Oct 5, 2023
Summary: Revamped version of pytorch#3234 (which was also revamp of pytorch#2850) Differential Revision: D49197174 Pulled By: mthrok
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Oct 5, 2023
Summary: Revamped version of pytorch#3234 (which was also revamp of pytorch#2850) Differential Revision: D49197174 Pulled By: mthrok
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Oct 5, 2023
Summary: Revamped version of pytorch#3234 (which was also revamp of pytorch#2850) Differential Revision: D49197174 Pulled By: mthrok
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Oct 9, 2023
Summary: Revamped version of pytorch#3234 (which was also revamp of pytorch#2850) Differential Revision: D49197174 Pulled By: mthrok
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Oct 9, 2023
Summary: Revamped version of pytorch#3234 (which was also revamp of pytorch#2850) Differential Revision: D49197174 Pulled By: mthrok
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Oct 9, 2023
Summary: Revamped version of pytorch#3234 (which was also revamp of pytorch#2850) Differential Revision: D49197174 Pulled By: mthrok
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Oct 13, 2023
Summary: Revamped version of pytorch#3234 (which was also revamp of pytorch#2850) Differential Revision: D49197174 Pulled By: mthrok
|
Addressed via #3655 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
ray_tracing()helper to compute a RIR (part of #2624). The implementation is heavily based onpyroomacoustics.Current status: support for 2D and 3D shoebox room is OK, results are very very close to those ofReady for reviewpyroomacoustics.My C++ is weak / rusty, so any suggestion on style / perf / best practices are more than welcome.
Lots of TODOs left:Donemake autograd work properlyLeaving this as potential future work as it is not immediately needednum_raysCC @nateanl