Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set release version and base PyTorch version for 1.11 pytorch release #2210

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

nateanl
Copy link
Member

@nateanl nateanl commented Feb 9, 2022

Ppdate circle ci torchaudio/pytorch versions for release

@hwangjeff
Copy link
Contributor

looks like there's overlap with #2209 — do you want to sync with @atalman?

fi
echo "export UPLOAD_CHANNEL=${our_upload_channel}" >> ${BASH_ENV}
# Hardcoded for release branch
echo "export UPLOAD_CHANNEL=test" >> ${BASH_ENV}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we on the release branch, why is this change required ? It should automatically use test, correct ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to @mthrok : Even though UPLOAD_CHANNEL is set to test if the branch name is release/*, when you are making a PR against the release branch, the value of CIRCLE_BRANCH is something like pr/XXX, and the CI jobs of PRs against release branches use nightly builds.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct. We need this for invoking signal for CI like. CicleCI's spec could have changed but it's safe to hard code this.

#1690

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it! Thanks for explanation.

@atalman atalman changed the title Set release version and base PyTorch version Set release version and base PyTorch version for 1.11 pytorch release Feb 10, 2022
@nateanl
Copy link
Member Author

nateanl commented Feb 10, 2022

close and re-open to trigger the tests.

@nateanl nateanl closed this Feb 10, 2022
@nateanl nateanl reopened this Feb 10, 2022
@nateanl nateanl merged commit 468faf5 into pytorch:release/0.11 Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants