Add abstraction for download util #1959
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D32078361 |
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Jul 13, 2022
Summary: Pull Request resolved: pytorch#1959 Differential Revision: D32078361 fbshipit-source-id: 02e4b0d38cfb278d4a3fe2bc12380674e0c596f9
mthrok
force-pushed
the
export-D32078361-to-fbsync
branch
from
22331ca to
927c0e0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D32078361 |
mthrok
pushed a commit
to mthrok/audio
that referenced
this pull request
Dec 13, 2022
* Adding FSDP advanced tutorial on T5 training * FSDP advanced featues in progress * removing old flow charts * clean up * clean up * clean up * clean up * intro updates * Updates on features * typos correction * Update sharding strategy * adding cross ref * Update FSDP_adavnced_tutorial.rst * Update FSDP_adavnced_tutorial.rst * added summary to the end * added reference to code section for adding each feature * update text grammar and minor details for top section * removed activation checkpointing * various grammar cleanup and minor explanatory additions (upper section) * update transformer wrapping policy and mixed precision * complete edits/updates for feature sections * add bolded summary * updated the backward prefetch * update the example link * Update FSDP_adavnced_tutorial.rst * update authors * minor spelling fixes * typos fix * Update intermediate_source/FSDP_adavnced_tutorial.rst Co-authored-by: Svetlana Karslioglu <[email protected]> * Update intermediate_source/FSDP_adavnced_tutorial.rst Co-authored-by: Svetlana Karslioglu <[email protected]> * Update intermediate_source/FSDP_adavnced_tutorial.rst Co-authored-by: Svetlana Karslioglu <[email protected]> * Update intermediate_source/FSDP_adavnced_tutorial.rst Co-authored-by: Svetlana Karslioglu <[email protected]> * Update intermediate_source/FSDP_adavnced_tutorial.rst Co-authored-by: Svetlana Karslioglu <[email protected]> * Update intermediate_source/FSDP_adavnced_tutorial.rst Co-authored-by: Svetlana Karslioglu <[email protected]> * Update intermediate_source/FSDP_adavnced_tutorial.rst Co-authored-by: Svetlana Karslioglu <[email protected]> * clean up * Update intermediate_source/FSDP_adavnced_tutorial.rst Co-authored-by: Svetlana Karslioglu <[email protected]> * addressing comments * addressed backward prefetch comments * addressed the comment on model checkpoint saving * Addressing the zero2 comments and overview of FSDP * Update intermediate_source/FSDP_adavnced_tutorial.rst Co-authored-by: Svetlana Karslioglu <[email protected]> * updates based on comments * FSDP wrapper comments * updated with additional comments * updated the bfloat16 memory * updating the title separator * Update intermediate_source/FSDP_adavnced_tutorial.rst Co-authored-by: Svetlana Karslioglu <[email protected]> * Update intermediate_source/FSDP_adavnced_tutorial.rst Co-authored-by: Svetlana Karslioglu <[email protected]> * Update intermediate_source/FSDP_adavnced_tutorial.rst Co-authored-by: Svetlana Karslioglu <[email protected]> * Update intermediate_source/FSDP_adavnced_tutorial.rst Co-authored-by: Svetlana Karslioglu <[email protected]> * Update intermediate_source/FSDP_adavnced_tutorial.rst Co-authored-by: Svetlana Karslioglu <[email protected]> * Update intermediate_source/FSDP_adavnced_tutorial.rst Co-authored-by: Svetlana Karslioglu <[email protected]> * Update intermediate_source/FSDP_adavnced_tutorial.rst Co-authored-by: Svetlana Karslioglu <[email protected]> * Update intermediate_source/FSDP_adavnced_tutorial.rst Co-authored-by: Svetlana Karslioglu <[email protected]> * Update intermediate_source/FSDP_adavnced_tutorial.rst Co-authored-by: Svetlana Karslioglu <[email protected]> * Update intermediate_source/FSDP_adavnced_tutorial.rst Co-authored-by: Svetlana Karslioglu <[email protected]> * addressing comments on code consistency * remove CPUoffload import * mixed precision re-wording * addressing comments Co-authored-by: Less Wright <[email protected]> Co-authored-by: Svetlana Karslioglu <[email protected]>
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Aug 7, 2023
Summary: Pull Request resolved: pytorch#1959 Differential Revision: D32078361 fbshipit-source-id: 2ea4dc20075eea7ab8f64c3910030d4b7fed0991
mthrok
force-pushed
the
export-D32078361-to-fbsync
branch
from
927c0e0 to
1e334c4
Compare
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/1959
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit f4e39f8: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D32078361 |
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Aug 7, 2023
Summary: Pull Request resolved: pytorch#1959 Differential Revision: D32078361 fbshipit-source-id: 1eaed749a117abfd1dcffe9a52b832f2c4499732
mthrok
force-pushed
the
export-D32078361-to-fbsync
branch
from
1e334c4 to
4f9ff20
Compare
|
This pull request was exported from Phabricator. Differential Revision: D32078361 |
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Aug 7, 2023
Summary: Pull Request resolved: pytorch#1959 Reviewed By: hwangjeff Differential Revision: D32078361 fbshipit-source-id: d6c4a28a4c633442bf013d41e9af854d26e4a46a
mthrok
force-pushed
the
export-D32078361-to-fbsync
branch
from
4f9ff20 to
13f9f56
Compare
|
This pull request was exported from Phabricator. Differential Revision: D32078361 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D32078361 |
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Aug 7, 2023
Summary: Pull Request resolved: pytorch#1959 Reviewed By: hwangjeff Differential Revision: D32078361 fbshipit-source-id: c45945abe20b7b1b271b0bc5161c58aec24be5a7
mthrok
force-pushed
the
export-D32078361-to-fbsync
branch
from
13f9f56 to
d993169
Compare
Summary: Pull Request resolved: pytorch#1959 Reviewed By: hwangjeff Differential Revision: D32078361 fbshipit-source-id: 5a886aaa29ed93e1d74439ebcd75313d32a91c64
mthrok
force-pushed
the
export-D32078361-to-fbsync
branch
from
d993169 to
f4e39f8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D32078361 |
|
This pull request has been merged in 3f98fb9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D32078361