[lts/release/1.8] packaging: Ensure we're propagating BUILD_VERSION (#1697) #1701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BUILD_VERSION gets set by upstream scripts and should be available whenever we're attempting to build audio in conda environments. This solves the issue where conda packages appeared to be building a development version instead of the actual version we were targeting Signed-off-by: Eli Uriegas <[email protected]> (cherry picked from commit 4c57e1b) Signed-off-by: Eli Uriegas <[email protected]>
zhouzhuojie
approved these changes
Aug 12, 2021
mthrok
pushed a commit
to mthrok/audio
that referenced
this pull request
Dec 13, 2022
* corrected a typo Signed-off-by: kiranscaria <[email protected]> * corrected a typo Signed-off-by: kiranscaria <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #1697 for 0.8 LTS release