Renaming fpx to floatx #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: att, to allow float8 code to be moved to floatx folder fpx_weight_only is not yet renamed to floatx_weight_only yet, we'll do that in the future after we have more clarity on what specific dtypes we want to support (e.g. maybe we'll just support fp4, fp6) Test Plan: python test/dtypes/test_floatx.py Reviewers: Subscribers: Tasks: Tags:
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/877
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 3a5517a with merge base 85d03de ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
jerryzh168
requested review from
msaroufim,
jainapurva,
gau-nernst and
drisspg
gau-nernst
approved these changes
Sep 12, 2024
jainapurva
pushed a commit
that referenced
this pull request
Sep 22, 2024
* Renaming fpx to floatx Summary: att, to allow float8 code to be moved to floatx folder fpx_weight_only is not yet renamed to floatx_weight_only yet, we'll do that in the future after we have more clarity on what specific dtypes we want to support (e.g. maybe we'll just support fp4, fp6) Test Plan: python test/dtypes/test_floatx.py Reviewers: Subscribers: Tasks: Tags: * fix test_ops
jainapurva
pushed a commit
that referenced
this pull request
Sep 23, 2024
* Renaming fpx to floatx Summary: att, to allow float8 code to be moved to floatx folder fpx_weight_only is not yet renamed to floatx_weight_only yet, we'll do that in the future after we have more clarity on what specific dtypes we want to support (e.g. maybe we'll just support fp4, fp6) Test Plan: python test/dtypes/test_floatx.py Reviewers: Subscribers: Tasks: Tags: * fix test_ops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
renaming to floatx to be aligned with the naming of float8, and to allow float8 code to be moved to floatx folder fpx_weight_only is not yet renamed to floatx_weight_only yet, we'll do that in the future after we have more clarity on what specific dtypes we want to support (e.g. maybe we'll just support fp4, fp6)
Test Plan:
python test/dtypes/test_floatx.py
Reviewers:
Subscribers:
Tasks:
Tags: