Lint fixes #1 torchao/dtypes #827
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/827
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 1d0da7c with merge base 88440e8 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
jainapurva
force-pushed
the
lint_fixes#1_torchao/dtype
branch
from
9ffbb0e
to
1aa8839
Compare
| 1: [1, 5, 9, 13, 17, 21, 25, 29, 3, 7, 11, 15, 19, 23, 27, 31, | ||
| 0, 4, 8, 12, 16, 20, 24, 28, 2, 6, 10, 14, 18, 22, 26, 30], | ||
| 1: [ | ||
| 1, |
There was a problem hiding this comment.
lol this is a fun result of this lint...
There was a problem hiding this comment.
This is auto-formatted in ruff. If I change the format, the CI/CD test for ruff format --check fails.
There was a problem hiding this comment.
does ruff support some kind of skipping a block of code? I know black has # fmt: off/on. This is one of the cases where auto-format tools make things worse 😄
| @@ -1,7 +1,6 @@ | |||
| import torch | |||
| from typing import Tuple, Optional, Union | |||
| from collections import defaultdict | |||
| import functools | |||
| import torchao.ops | |||
There was a problem hiding this comment.
I suspect this line broke our binary builds. This seems to be such an easy mistake to make so need to think of a better solution
There was a problem hiding this comment.
yeah is this caught by normal PR CI btw?
Revert "Lint fixes #1 torchao/dtypes (#827)" This reverts commit 144445a. Co-authored-by: Mark Saroufim <[email protected]>
Revert "Lint fixes #1 torchao/dtypes (#827)" This reverts commit 144445a. Co-authored-by: Mark Saroufim <[email protected]>
Performed lint fixes in directory: torchao/dtypes