-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Float8Quant] Add rowwise scaling option to float8 dyanmic quant #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/819
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 0405f9e with merge base 65d86c6 (): FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
drisspg
added a commit
that referenced
this pull request
Sep 5, 2024
stack-info: PR: #819, branch: drisspg/stack/11
drisspg
force-pushed
the
drisspg/stack/11
branch
from
September 5, 2024 22:36
b34f889
to
45997fe
Compare
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Sep 5, 2024
drisspg
added a commit
that referenced
this pull request
Sep 5, 2024
stack-info: PR: #819, branch: drisspg/stack/11
drisspg
force-pushed
the
drisspg/stack/11
branch
from
September 5, 2024 22:39
45997fe
to
31ef688
Compare
drisspg
commented
Sep 5, 2024
drisspg
added a commit
that referenced
this pull request
Sep 5, 2024
stack-info: PR: #819, branch: drisspg/stack/11
drisspg
force-pushed
the
drisspg/stack/11
branch
from
September 5, 2024 22:48
31ef688
to
06a5628
Compare
vkuzo
reviewed
Sep 5, 2024
drisspg
added a commit
that referenced
this pull request
Sep 6, 2024
stack-info: PR: #819, branch: drisspg/stack/11
drisspg
force-pushed
the
drisspg/stack/11
branch
from
September 6, 2024 17:28
06a5628
to
7c65d88
Compare
drisspg
added a commit
that referenced
this pull request
Sep 6, 2024
stack-info: PR: #819, branch: drisspg/stack/11
drisspg
force-pushed
the
drisspg/stack/11
branch
from
September 6, 2024 19:06
7c65d88
to
8bf08db
Compare
drisspg
added a commit
that referenced
this pull request
Sep 6, 2024
stack-info: PR: #819, branch: drisspg/stack/11
drisspg
force-pushed
the
drisspg/stack/11
branch
from
September 6, 2024 19:41
8bf08db
to
a3307f6
Compare
drisspg
added a commit
that referenced
this pull request
Sep 6, 2024
stack-info: PR: #819, branch: drisspg/stack/11
drisspg
force-pushed
the
drisspg/stack/11
branch
from
September 6, 2024 19:43
a3307f6
to
5d3683d
Compare
drisspg
added a commit
that referenced
this pull request
Sep 6, 2024
stack-info: PR: #819, branch: drisspg/stack/11
drisspg
force-pushed
the
drisspg/stack/11
branch
from
September 6, 2024 22:19
5d3683d
to
407528d
Compare
drisspg
added a commit
that referenced
this pull request
Sep 6, 2024
stack-info: PR: #819, branch: drisspg/stack/11
drisspg
force-pushed
the
drisspg/stack/11
branch
from
September 6, 2024 22:38
407528d
to
b3eb6a7
Compare
drisspg
changed the title
[Float8Quant] Add rowwise scaling option to float8 dyanmic quant
[Float8Quant] Add PerRow scaling option to float8 dyanmic quant
Sep 6, 2024
drisspg
changed the title
[Float8Quant] Add PerRow scaling option to float8 dyanmic quant
[Float8Quant] Add PerRow scaling option to float8 dynamic quant
Sep 6, 2024
drisspg
added a commit
that referenced
this pull request
Sep 6, 2024
stack-info: PR: #819, branch: drisspg/stack/11
drisspg
force-pushed
the
drisspg/stack/11
branch
from
September 6, 2024 22:57
b3eb6a7
to
aac19a1
Compare
drisspg
changed the title
[Float8Quant] Add PerRow scaling option to float8 dynamic quant
[Float8Quant] Add rowwise scaling option to float8 dyanmic quant
Sep 6, 2024
jerryzh168
reviewed
Sep 6, 2024
jerryzh168
reviewed
Sep 6, 2024
jerryzh168
reviewed
Sep 6, 2024
jerryzh168
reviewed
Sep 6, 2024
jerryzh168
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
drisspg
added a commit
that referenced
this pull request
Sep 7, 2024
stack-info: PR: #819, branch: drisspg/stack/11
drisspg
force-pushed
the
drisspg/stack/11
branch
from
September 7, 2024 00:51
aac19a1
to
1dface2
Compare
drisspg
added a commit
that referenced
this pull request
Sep 7, 2024
stack-info: PR: #819, branch: drisspg/stack/11
drisspg
force-pushed
the
drisspg/stack/11
branch
from
September 7, 2024 01:07
1dface2
to
eae3b8f
Compare
stack-info: PR: #819, branch: drisspg/stack/11
drisspg
force-pushed
the
drisspg/stack/11
branch
from
September 7, 2024 01:10
eae3b8f
to
0405f9e
Compare
andrewor14
pushed a commit
that referenced
this pull request
Sep 9, 2024
jainapurva
pushed a commit
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
[Float8Quant] Add rowwise scaling option to float8 dyanmic quant
Summary
Adds an option to do PerRow scaling of the activation and weight, which can provide faster activation quantization and better numerics.
The api for calling this is: