[NF4] Freeze dataclass | prep for better pt2 support #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/799
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 639f7d2 with merge base e15e509 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
drisspg
added a commit
that referenced
this pull request
Sep 3, 2024
stack-info: PR: #799, branch: drisspg/stack/6
drisspg
force-pushed
the
drisspg/stack/6
branch
from
66bea24 to
0a50f35
Compare
facebook-github-bot
added
the
CLA Signed
drisspg
requested review from
mlazos,
chunweiliu,
msaroufim and
weifengpy
and removed request for
chunweiliu
weifengpy
approved these changes
Sep 3, 2024
mlazos
approved these changes
Sep 3, 2024
msaroufim
approved these changes
Sep 3, 2024
stack-info: PR: #799, branch: drisspg/stack/6
drisspg
force-pushed
the
drisspg/stack/6
branch
from
0a50f35 to
639f7d2
Compare
weifengpy
reviewed
Sep 3, 2024
| @@ -376,7 +376,7 @@ def nf4_pin_memory(aten_op, args, kwargs=None): | |||
| return NF4Tensor(*construct_nf4_args(nf4tensor, updated_attrs)) | |||
|
|
|||
|
|
|||
| @dataclass | |||
| @dataclass(frozen=True) | |||
There was a problem hiding this comment.
curious how is frozen=True related to PT2?
jerryzh168
pushed a commit
to jerryzh168/ao
that referenced
this pull request
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
[NF4] Freeze dataclass | prep for better pt2 support