Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2bit packing routines #797

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

metascroy
Copy link
Contributor

Summary:
Adds 2-bit packing/unpacking routines, together with tests/benchmarks.

This adds 24 new 2 bit kernels (3 tile sizes x 8 variants).

Reviewed By: digantdesai

Differential Revision: D62133659

Copy link

pytorch-bot bot commented Sep 3, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/797

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c781cbd with merge base e15e509 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 3, 2024
@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D62133659

Summary:
Pull Request resolved: pytorch#797

Adds 2-bit packing/unpacking routines, together with tests/benchmarks.

This adds 24 new 2 bit kernels (3 tile sizes x 8 variants).

Reviewed By: digantdesai

Differential Revision: D62133659
@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D62133659

@facebook-github-bot facebook-github-bot merged commit d980858 into pytorch:main Sep 3, 2024
18 of 19 checks passed
jerryzh168 pushed a commit to jerryzh168/ao that referenced this pull request Sep 4, 2024
Differential Revision: D62133659

Pull Request resolved: pytorch#797
yanbing-j pushed a commit to yanbing-j/ao that referenced this pull request Dec 9, 2024
Update prompt chat is waiting for, which was modified by pytorch/torchchat#476

Modify logging defaults to not create a file in a temp folder without prompting user, but rather just print an info messages Replace few `prints` with `logging.info` This way, information about bandwith achieved will be printed to the console, but not to the web-browser chat window

Test plan:
```
% python3 torchchat.py browser stories110M &
% curl -L http://127.0.0.1:5000
% curl -d "prompt=Once upon a time" -X POST http://127.0.0.1:5000/chat
```

TODOs: 
- Add CI that repeats above steps
-Figure out if spawning generator from the browser can be avoided

Fixes pytorch/torchchat#785
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants