Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify output dtype to torch.float32 in _foreach_norm #727

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

crcrpar
Copy link
Contributor

@crcrpar crcrpar commented Aug 22, 2024

follow-up of #713

Signed-off-by: Masaki Kozuki <[email protected]>
Copy link

pytorch-bot bot commented Aug 22, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/727

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a0376bf with merge base cdb25a4 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 22, 2024
@msaroufim msaroufim requested review from vkuzo and weifengpy August 22, 2024 05:47
Copy link
Contributor

@weifengpy weifengpy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is even better for numerics. thanks for proposing

@msaroufim msaroufim merged commit c0b0731 into pytorch:main Aug 22, 2024
16 checks passed
@crcrpar crcrpar deleted the foreach_norm_with_dtype branch August 22, 2024 18:02
yanbing-j pushed a commit to yanbing-j/ao that referenced this pull request Dec 9, 2024
* Update et-pin.txt to get rid of torch dependency

As titled. Starting from that commit we don't need to pull torch anymore.

* Update to the latest

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants