Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move developer guide file to a folder #681

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

jerryzh168
Copy link
Contributor

Summary:
Moved the dev api guide to a folder and we plan to add more developer guide examples e.g.

developer_api_guide/training.py - how to make a tensor subclass trainable
developer_api_guide/fsdp.py - how to make a tensor subclass work with fsdp
developer_api_guide/tensor_parallel.py - how to make a tensor subclass work with tensor parallelism
developer_api_guide/autoquant.py - how to make a tensor subclass work with autoquant
...

Test Plan:
python test/tutorials/developer_api_guide/my_dtype_tensor_subclass.py

Reviewers:

Subscribers:

Tasks:

Tags:

Copy link

pytorch-bot bot commented Aug 14, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/681

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a80c67c with merge base 582b6d4 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 14, 2024
@msaroufim
Copy link
Member

Can you show a screenshot of how this looks like on the page now? preview link isnt working for me

@jerryzh168
Copy link
Contributor Author

jerryzh168 commented Aug 14, 2024

@msaroufim this is not a doc change, this is talking about runnable dev api guide code, moved code from notebook to our code base so we can keep the APIs up to date: #588

Summary:
Moved the dev api guide to a folder and we plan to add more developer guide examples
e.g.
```
developer_api_guide/training.py - how to make a tensor subclass trainable
developer_api_guide/fsdp.py - how to make a tensor subclass work with fsdp
developer_api_guide/tensor_parallel.py - how to make a tensor subclass work with tensor parallelism
developer_api_guide/autoquant.py - how to make a tensor subclass work with autoquant
...
```

Test Plan:
python test/tutorials/developer_api_guide/my_dtype_tensor_subclass.py

Reviewers:

Subscribers:

Tasks:

Tags:
@jerryzh168 jerryzh168 merged commit 5998389 into pytorch:main Aug 15, 2024
14 checks passed
@jerryzh168 jerryzh168 deleted the dev-guide-folder branch August 15, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants