Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove numpy as bitpack dependency #677

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Remove numpy as bitpack dependency #677

merged 1 commit into from
Aug 14, 2024

Conversation

msaroufim
Copy link
Member

@msaroufim msaroufim commented Aug 14, 2024

main builds are broken because we are now accidentally dependending on numpy https://github.com/pytorch/ao/commits/main/

AO as of now has no dependencies

Tests seem fine

(ao) [[email protected] ~/test/ebs-torchtune (debug)]$ pip list | grep numpy
(ao) [[email protected] ~/test/ebs-torchtune (debug)]$ 
test_uintx.py ....................................................................................               [100%]

=================================================== warnings summary ===================================================
../../../.conda/envs/ao/lib/python3.10/site-packages/torch/_subclasses/functional_tensor.py:271
  /home/marksaroufim/.conda/envs/ao/lib/python3.10/site-packages/torch/_subclasses/functional_tensor.py:271: UserWarning: Failed to initialize NumPy: No module named 'numpy' (Triggered internally at ../torch/csrc/utils/tensor_numpy.cpp:84.)
    cpu = _conversion_method_template(device=torch.device("cpu"))

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
====================================== 84 passed, 1 warning in 291.43s (0:04:51) =======================================
(ao) [[email protected] ~/ao/test/dtypes (main)]$ 

main builds are broken because we are now accidentally dependending on numpy

AO as of now has no dependencies
Copy link

pytorch-bot bot commented Aug 14, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/677

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b2e86b1 with merge base 009f55f (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@msaroufim msaroufim requested a review from vayuda August 14, 2024 17:10
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 14, 2024
@msaroufim msaroufim requested a review from jerryzh168 August 14, 2024 17:11
@msaroufim msaroufim merged commit acfb0da into main Aug 14, 2024
13 checks passed
@msaroufim msaroufim deleted the msaroufim-patch-15 branch August 14, 2024 17:19
yanbing-j pushed a commit to yanbing-j/ao that referenced this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants