Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip fsdp2 low bit optim test in nightlies #653

Merged
merged 3 commits into from
Aug 11, 2024
Merged

Conversation

msaroufim
Copy link
Member

@msaroufim msaroufim commented Aug 10, 2024

Temporary workaround for #652

I didn't debug this but seems like it's some dynamic shape issue - cc @ezyang @gau-nernst

Copy link

pytorch-bot bot commented Aug 10, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/653

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5dd8996 with merge base 91dc371 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 10, 2024
@msaroufim msaroufim requested a review from gau-nernst August 10, 2024 22:31
@gau-nernst
Copy link
Collaborator

The FSDP test only run in nightly, so if we skip, it won't run at all. Will try if I can debug it today.
Also, are you looking at adding 2.4 to CI?

@gau-nernst
Copy link
Collaborator

gau-nernst commented Aug 10, 2024

If this test succeeds in 2.4 (observing #654), I will approve this. Otherwise, will try if I can fix it today. This is also affecting my #644, probably because I also use optimizer from low_bit_optim for the quantized training FSDP test.

@msaroufim msaroufim merged commit 261d0a4 into main Aug 11, 2024
14 checks passed
@msaroufim msaroufim deleted the msaroufim-patch-15 branch August 11, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants