float8 profiling: save torch_logs, and attach them to profiling trace #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/645
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 226ef65 with merge base 433cd14 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
y-sq
approved these changes
Aug 9, 2024
Summary: Adds two extra things to benchmarks/float8/profile_linear_float8.py: 1. for each profiling run, also saves the output of `TORCH_LOGS="output_code"` 2. for each profiling trace, creates a modified trace with the inductor code from (1) attached to triton kernel GPU events, which enables the user to click on the triton kernels in `chrome://tracing/` or perfetto, and see the triton code inline in the browser - no need to cross reference against logs anymore. Test Plan: Reviewers: Subscribers: Tasks: Tags:
vkuzo
force-pushed
the
20240809_f8_profile_update_trace
branch
from
aef0176 to
226ef65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adds two extra things to benchmarks/float8/profile_linear_float8.py:
TORCH_LOGS="output_code"chrome://tracing/or perfetto, and see the triton code inline in the browser - no need to cross reference against logs anymore.Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: