Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] store inv_scale on Float8Tensor #628

Closed
wants to merge 5 commits into from
Closed

[wip] store inv_scale on Float8Tensor #628

wants to merge 5 commits into from

Conversation

vkuzo
Copy link
Contributor

@vkuzo vkuzo commented Aug 7, 2024

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

vkuzo added 4 commits August 6, 2024 14:29
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@vkuzo
Copy link
Contributor Author

vkuzo commented Aug 7, 2024

Stack from ghstack (oldest at bottom):

Copy link

pytorch-bot bot commented Aug 7, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/628

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 71ced0f with merge base d582f9a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 7, 2024
vkuzo added a commit that referenced this pull request Aug 7, 2024
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 6ab4322ffb9456f244a1c3987842e10f3ecc2a83
ghstack-comment-id: 2273795212
Pull Request resolved: #628
[ghstack-poisoned]
@vkuzo vkuzo changed the base branch from gh/vkuzo/7/head to main August 7, 2024 16:33
vkuzo added a commit that referenced this pull request Aug 7, 2024
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 6ab4322ffb9456f244a1c3987842e10f3ecc2a83
ghstack-comment-id: 2273795212
Pull Request resolved: #628
yanbing-j pushed a commit to yanbing-j/ao that referenced this pull request Dec 9, 2024
As per Soumith's original statement, pytorch#389
@vkuzo vkuzo closed this Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants