Skip to content

Update README.md #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Update README.md #618

merged 1 commit into from
Aug 7, 2024

Conversation

raziel
Copy link
Contributor

@raziel raziel commented Aug 6, 2024

Fixes comment for when to use unwrap_tensor_subclass

Fixes comment for when to use unwrap_tensor_subclass
Copy link

pytorch-bot bot commented Aug 6, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/618

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b743fde with merge base ac03072 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 6, 2024
jerryzh168
jerryzh168 previously approved these changes Aug 6, 2024
Copy link
Contributor

@jerryzh168 jerryzh168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

jerryzh168
jerryzh168 previously approved these changes Aug 6, 2024
Copy link
Contributor

@jerryzh168 jerryzh168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@raziel raziel closed this Aug 6, 2024
@raziel raziel reopened this Aug 6, 2024
@pytorch-bot pytorch-bot bot dismissed stale reviews from jerryzh168 and jerryzh168 August 6, 2024 22:31

This PR was reopened (likely due to being reverted), so your approval was removed. Please request another review.

@raziel
Copy link
Contributor Author

raziel commented Aug 6, 2024

Sorry, clicked wrong button by mistake. Not used to not being able to merge PRs :-)

@raziel raziel requested a review from jerryzh168 August 6, 2024 22:32
@msaroufim msaroufim self-requested a review August 7, 2024 02:58
@msaroufim msaroufim merged commit acb2b56 into pytorch:main Aug 7, 2024
13 checks passed
jainapurva pushed a commit that referenced this pull request Aug 7, 2024
Fixes comment for when to use unwrap_tensor_subclass
yanbing-j pushed a commit to yanbing-j/ao that referenced this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants