Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable float8 CI on sm89 #587

Merged
merged 29 commits into from
Aug 7, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Test on torch latest version
  • Loading branch information
jainapurva committed Aug 7, 2024
commit 521da1073b90ebc54c83d300984f10c3f9ae7d15
3 changes: 1 addition & 2 deletions .github/workflows/float8_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ jobs:
include:
- name: SM-89
runs-on: amz2023.linux.g6.4xlarge.experimental.nvidia.gpu
torch-spec: '--pre torch==2.5.0.dev20240728+cu121 --index-url https://download.pytorch.org/whl/nightly/cu121'
gpu-arch-type: "cuda"
gpu-arch-version: "12.1"

Expand All @@ -40,7 +39,7 @@ jobs:
yum install -y devtoolset-10-binutils
export PATH=/opt/rh/devtoolset-10/root/usr/bin/:$PATH
python -m pip install --upgrade pip
pip install ${{ matrix.torch-spec }}
pip install torch
pip install -r dev-requirements.txt
pip install .
pytest test/float8 --verbose -s
3 changes: 2 additions & 1 deletion test/float8/test_fsdp2/test_fsdp2.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@
)

is_H100 = torch.cuda.is_available() and torch.cuda.get_device_capability() >= (9, 0)
if not is_H100:
is_cuda_8_9 = torch.cuda.is_available() and torch.cuda.get_device_capability() >= (8, 9)
if not is_cuda_8_9:
pytest.skip("Unsupported CUDA device capability version", allow_module_level=True)

class TestFloat8Common:
Expand Down
Loading