Refactor QAT into its own module #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/555
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit cf7f651 with merge base ec317fc ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
msaroufim
approved these changes
Jul 30, 2024
test/quantization/test_qat.py
Outdated
| @@ -455,7 +455,7 @@ def test_qat_4w_linear(self): | |||
| # TODO: remove once we fix int4 error: https://github.com/pytorch/ao/pull/517 | |||
| @unittest.skipIf(TORCH_VERSION_AFTER_2_5, "int4 doesn't work for 2.5+ right now") | |||
| def test_qat_4w_quantizer(self): | |||
| from torchao.quantization.prototype.qat import Int4WeightOnlyQATQuantizer | |||
| from torchao.quantization.prototype.qat.api import Int4WeightOnlyQATQuantizer | |||
There was a problem hiding this comment.
This renaming seems worse and I don't believe you need it since Int4WeightOnlyQATQuantizer is part of qat/__init__.py
jerryzh168
approved these changes
Jul 30, 2024
Summary: Refactor QAT into its own module so future QAT features can live under the same folder without making qat.py longer, and a separate QAT README can be added in the future. Test Plan: python test/quantization/test_qat.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Refactor QAT into its own module so future QAT features can live under the same folder without making qat.py longer, and a separate QAT README can be added in the future.
Test Plan:
python test/quantization/test_qat.py