Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git version suffix to package name #547

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Add git version suffix to package name #547

merged 2 commits into from
Jul 31, 2024

Conversation

msaroufim
Copy link
Member

@msaroufim msaroufim commented Jul 26, 2024

fixes #546

Problem

It's not clear when you install ao looking at the version number if it was installed from source or not

This PR

We add the latest commit ID of the current branch to the name. So you can unambiguously tell if ao is installed from source or not by checking if there's a +git in the name

I'm not sure if this breaks internal in some mysterious way and I think this is safe as far as naming official binaries go

Proof

(ao) [[email protected] ~/ao (msaroufim/git)]$ USE_CPP=0 pip install .
Processing /home/marksaroufim/ao
  Preparing metadata (setup.py) ... done
Building wheels for collected packages: torchao
  Building wheel for torchao (setup.py) ... done
  Created wheel for torchao: filename=torchao-0.3.1+gitd1c3046-py3-none-any.whl size=245573 sha256=22e3b8d62c8d1eef9486cc267471bfcf138dcd7430b12b4f1e715708e1c01b5b
  Stored in directory: /tmp/pip-ephem-wheel-cache-xwwsb6vd/wheels/98/63/17/f0c8348dc6feec64a509f5107bbf0075300ccb8e8619b8a8b0
Successfully built torchao
Installing collected packages: torchao
  Attempting uninstall: torchao
    Found existing installation: torchao 0.3.1+gitd1c3046
    Uninstalling torchao-0.3.1+gitd1c3046:
      Successfully uninstalled torchao-0.3.1+gitd1c3046
Successfully installed torchao-0.3.1+gitd1c3046
(ao) [[email protected] ~/ao (msaroufim/git)]$ pip show torchao
Name: torchao
Version: 0.3.1+gitd1c3046

Copy link

pytorch-bot bot commented Jul 26, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/547

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit fac5337 with merge base 5787e9e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 26, 2024
@msaroufim msaroufim requested review from atalman and ebsmothers July 26, 2024 22:12
Copy link
Contributor

@ebsmothers ebsmothers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👑

@msaroufim msaroufim merged commit 0cc1c4d into main Jul 31, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] Append torchao version with commit hash when installing from source
5 participants