Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the impl for to for int4 weight only use case #522

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

jerryzh168
Copy link
Contributor

@jerryzh168 jerryzh168 commented Jul 17, 2024

Summary:
Note that we can do the following right now:

  • initialize and quantize the model with int4_weight_only quant in cpu
  • move the model to cuda

we'll enable this in a separate PR

Test Plan:
python test/quantization/test_quant_api.py -k test_int4wo_quantized_model_to_device
Reviewers:

Subscribers:

Tasks:

Tags:

Copy link

pytorch-bot bot commented Jul 17, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/522

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 3ed1a46 with merge base 6dd82d8 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@jerryzh168 jerryzh168 requested a review from msaroufim July 17, 2024 19:50
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 17, 2024
@jerryzh168 jerryzh168 requested a review from HDCharles July 17, 2024 19:50
@@ -637,6 +637,22 @@ def test_quantized_model_to_device(self):
cuda_res = m(*example_inputs_cuda)
self.assertEqual(cuda_res.cpu(), ref)

# TODO: enable this test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why disable test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cpu -> cuda does not work yet, I changed it to cuda to cuda for now

@jerryzh168 jerryzh168 force-pushed the test-to branch 2 times, most recently from 2019b80 to 948b7ed Compare July 17, 2024 20:40
Summary:
Note that we can do the following right now:
* initialize and quantize the model with int4_weight_only quant in cpu
* move the model to cuda

we'll enable this in a separate PR

Test Plan:
CI

Reviewers:

Subscribers:

Tasks:

Tags:
@jerryzh168 jerryzh168 merged commit d36de1b into pytorch:main Jul 17, 2024
13 checks passed
@jerryzh168 jerryzh168 deleted the test-to branch July 17, 2024 23:13
dbyoung18 pushed a commit to dbyoung18/ao that referenced this pull request Jul 31, 2024
Summary:
Note that we can do the following right now:
* initialize and quantize the model with int4_weight_only quant in cpu
* move the model to cuda

we'll enable this in a separate PR

Test Plan:
CI

Reviewers:

Subscribers:

Tasks:

Tags:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants