Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix torchtune in Genie #480

Merged
merged 1 commit into from
Jul 5, 2024
Merged

fix torchtune in Genie #480

merged 1 commit into from
Jul 5, 2024

Conversation

SLR722
Copy link
Contributor

@SLR722 SLR722 commented Jul 5, 2024

Summary:
fixes torchtune in Genie (all torchtune in Genie jobs are blocked by importlib.metadata.PackageNotFoundError: No package metadata was found for torch)

check is_fbcode before checking torch version. since python package version only works in OSS

Differential Revision: D59404942

Copy link

pytorch-bot bot commented Jul 5, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/480

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 719cabf with merge base a35a1cd (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 5, 2024
@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D59404942

Summary:
Pull Request resolved: pytorch#480

fixes torchtune in Genie (all torchtune in Genie jobs are blocked by importlib.metadata.PackageNotFoundError: No package metadata was found for torch)

check is_fbcode before checking torch version. since python package version only works in OSS

Differential Revision: D59404942
@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D59404942

@SLR722 SLR722 force-pushed the export-D59404942 branch from 32ef5ce to 719cabf Compare July 5, 2024 19:30
@msaroufim msaroufim self-requested a review July 5, 2024 20:36
@SLR722 SLR722 merged commit ec73788 into pytorch:main Jul 5, 2024
14 of 15 checks passed
dbyoung18 pushed a commit to dbyoung18/ao that referenced this pull request Jul 31, 2024
Summary:
Pull Request resolved: pytorch#480

fixes torchtune in Genie (all torchtune in Genie jobs are blocked by importlib.metadata.PackageNotFoundError: No package metadata was found for torch)

check is_fbcode before checking torch version. since python package version only works in OSS

Differential Revision: D59404942
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants