Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept device for Int8DynActInt4WeightQuantizer #475

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Conversation

larryliu0820
Copy link
Contributor

Before we migrate away from Quantizer APIs, we want to align the __init__ arguments between Int8DynActInt4WeightQuantizer and Int4WeightOnlyQuantizer so it's easier for users to use.

Before we migrate away from `Quantizer` APIs, we want to
align the `__init__` arguments between `Int8DynActInt4WeightQuantizer`
and `Int4WeightOnlyQuantizer` so it's easier for users to use.
Copy link

pytorch-bot bot commented Jul 3, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/475

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 439604a with merge base a895699 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 3, 2024
@larryliu0820 larryliu0820 requested a review from jerryzh168 July 3, 2024 21:56
Copy link
Contributor

@jerryzh168 jerryzh168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this the only place that needs to be fixed?

@larryliu0820 larryliu0820 merged commit 77c9304 into main Jul 3, 2024
13 checks passed
dbyoung18 pushed a commit to dbyoung18/ao that referenced this pull request Jul 31, 2024
Before we migrate away from `Quantizer` APIs, we want to
align the `__init__` arguments between `Int8DynActInt4WeightQuantizer`
and `Int4WeightOnlyQuantizer` so it's easier for users to use.
yanbing-j pushed a commit to yanbing-j/ao that referenced this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants