Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation Docs #459

Merged
merged 4 commits into from
Jun 28, 2024
Merged

Update installation Docs #459

merged 4 commits into from
Jun 28, 2024

Conversation

msaroufim
Copy link
Member

@msaroufim msaroufim commented Jun 28, 2024

We now no longer have a torch dependency and we have our binaries on the prod index

Copy link

pytorch-bot bot commented Jun 28, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/459

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 830f374 with merge base c2f9b84 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 28, 2024
@msaroufim msaroufim requested a review from supriyar June 28, 2024 17:21
@msaroufim msaroufim changed the title Update installation Update installation Docs Jun 28, 2024
README.md Outdated
@@ -83,15 +83,17 @@ A key design principle for us is composability as in any new dtype or layout we
### Installation
`torchao` makes liberal use of several new features in Pytorch, it's recommended to use it with the current nightly or latest stable version of PyTorch.

Stable release from Pypi which will default to PyTorch 2.3.1 and CUDA 12.1
Install the torch version you want from https://pytorch.org/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will any torch version work? The previous line suggests current nightly or latest stable. Can we add that explicitly here (and maybe remove that line)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made this clearer now

@msaroufim msaroufim merged commit e2263ff into main Jun 28, 2024
3 checks passed
@msaroufim msaroufim deleted the msaroufim-patch-10 branch June 28, 2024 18:58
dbyoung18 pushed a commit to dbyoung18/ao that referenced this pull request Jul 31, 2024
* Update installation

* Update README.md

* Update README.md

* Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants