Skip to content

[ROCm] Fix: Conditionally import torch.distributed to support builds without distributed#4017

Closed
0xDELUXA wants to merge 1 commit intopytorch:mainfrom
0xDELUXA:fix-torch-distributed-import
Closed

[ROCm] Fix: Conditionally import torch.distributed to support builds without distributed#4017
0xDELUXA wants to merge 1 commit intopytorch:mainfrom
0xDELUXA:fix-torch-distributed-import

Conversation

@0xDELUXA
Copy link
Copy Markdown

@0xDELUXA 0xDELUXA commented Mar 6, 2026

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Mar 6, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/4017

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla
Copy link
Copy Markdown

meta-cla bot commented Mar 6, 2026

Hi @0xDELUXA!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@0xDELUXA 0xDELUXA changed the title Fix: conditionally import torch.distributed in nf4tensor, adam, quant_utils Fix: Conditionally import torch.distributed in nf4tensor.py, adam.py, and quant_utils.py Mar 6, 2026
@meta-cla
Copy link
Copy Markdown

meta-cla bot commented Mar 6, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 6, 2026
@meta-cla
Copy link
Copy Markdown

meta-cla bot commented Mar 6, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@0xDELUXA 0xDELUXA changed the title Fix: Conditionally import torch.distributed in nf4tensor.py, adam.py, and quant_utils.py [ROCm] Fix: Conditionally import torch.distributed in nf4tensor.py, adam.py, and quant_utils.py Mar 6, 2026
@0xDELUXA 0xDELUXA force-pushed the fix-torch-distributed-import branch from 5b3d502 to 00ab8af Compare March 10, 2026 16:17
@0xDELUXA 0xDELUXA force-pushed the fix-torch-distributed-import branch 6 times, most recently from e38b36d to d21f924 Compare March 14, 2026 17:53
@0xDELUXA 0xDELUXA changed the title [ROCm] Fix: Conditionally import torch.distributed in nf4tensor.py, adam.py, and quant_utils.py [ROCm] Fix: Conditionally import torch.distributed to support builds without distributed Mar 14, 2026
@0xDELUXA 0xDELUXA marked this pull request as draft March 14, 2026 18:10
@0xDELUXA 0xDELUXA force-pushed the fix-torch-distributed-import branch 2 times, most recently from 9525be5 to d21289f Compare March 14, 2026 18:28
@0xDELUXA 0xDELUXA force-pushed the fix-torch-distributed-import branch from d21289f to 7f5f895 Compare March 14, 2026 18:49
@0xDELUXA
Copy link
Copy Markdown
Author

Tracked down all issues preventing import torchao from working on Windows ROCm. This ended up being quite a large set of changes, and I don’t think it’s feasible to get this merged. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: rocm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant