Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inductor config BC change #382

Merged
merged 6 commits into from
Jun 16, 2024
Merged

Fix inductor config BC change #382

merged 6 commits into from
Jun 16, 2024

Conversation

msaroufim
Copy link
Member

@msaroufim msaroufim commented Jun 15, 2024

Fixes #381

Interestingly enough when I ran the failed test from CI on a local H100 I could repro the accuracy degradation so I suspect this is an A10G specific accuracy issue so I will forgive myself and decrease the accuracy

  FAILED test/integration/test_integration.py::TestWeightOnlyInt8Quant::test_weight_only_quant_force_mixed_mm_5_cuda - AssertionError: tensor(42.5000, device='cuda:0', dtype=torch.bfloat16) not greater than or equal to 42.75

Copy link

pytorch-bot bot commented Jun 15, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/382

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 1e0b478 with merge base aa61c45 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 15, 2024
@msaroufim msaroufim merged commit 664f073 into main Jun 16, 2024
13 checks passed
NicoleMayer pushed a commit that referenced this pull request Jul 9, 2024
* Fix inductor config BC change

* yolo

* yolo

* yolo

* add

* Update test_integration.py
dbyoung18 pushed a commit to dbyoung18/ao that referenced this pull request Jul 31, 2024
* Fix inductor config BC change

* yolo

* yolo

* yolo

* add

* Update test_integration.py
yanbing-j pushed a commit to yanbing-j/ao that referenced this pull request Dec 9, 2024
* rename executable in runner-et to run to align with AOTI

* add missing quote

* download tokenizer.bin

* add -O
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

force_mixed_mm was deprecated in _inductor/config.py
3 participants