Revert "Clean up FP6-LLM" #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cd8f647.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/338
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit b49713b with merge base 8c8bc81 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
msaroufim
requested review from
gau-nernst and
jerryzh168
and removed request for
gau-nernst
gau-nernst
approved these changes
Jun 9, 2024
|
|
msaroufim
added a commit
that referenced
this pull request
Jun 10, 2024
Right now our binaries are built for python 3.8 wheras our CI tests 3.9 This was a problem for this PR #338 where it was using some fairly innocuous typing features that are not available on python 3.8. CI passed but binary build failed which meant we had to do a revert
dbyoung18
pushed a commit
to dbyoung18/ao
that referenced
this pull request
Jul 31, 2024
This reverts commit cd8f647.
yanbing-j
pushed a commit
to yanbing-j/ao
that referenced
this pull request
Dec 9, 2024
Added documentation about GPTQ, HQQ Various documentation fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #304
This is breaking our manylinux builds https://github.com/pytorch/ao/actions/runs/9438268458/job/25995073071
This was passing CI but failed at binary builds so we should have some way of detecting potential python compatibility issues earlier - cc @huydhn @atalman